Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect path for "browser" field in package.json #101

Closed
jluna opened this issue Jan 22, 2018 · 1 comment
Closed

Incorrect path for "browser" field in package.json #101

jluna opened this issue Jan 22, 2018 · 1 comment

Comments

@jluna
Copy link

jluna commented Jan 22, 2018 •
edited
Loading

Problem

When building a bundle with browserify, I received the very unhelpful error message that the module could not be found even though it was installed in ./node_modules via npm.

Error: Cannot find module './node_modules/@esri/arcgis-rest-auth'

Solution

After much confusion, poking, and prodding. I realized that the "browser" path hint in package.json was pointing to the wrong location. After fixing this locally browserify was able to find the correct distribution and build the bundle.

Example

https://github.com/Esri/arcgis-rest-js/blob/master/packages/arcgis-rest-request/package.json#L6
Presumably it's an issue for all packages.
@jgravois
Copy link
Contributor

thanks for the heads up @jluna! are you interested in submitting a Pull Request with the fix?

jgravois added a commit that referenced this issue Jan 22, 2018
@jgravois
refactor(package.json files and rollup config): ensure JS build tools…
ea4f59c 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101
@jgravois jgravois mentioned this issue Jan 22, 2018
Merged
jgravois added a commit to jgravois/arcgis-rest-js that referenced this issue Jan 23, 2018
@jgravois
refactor(package.json files and rollup config): ensure JS build tools…
e5e79de 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: Esri#101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

done
jgravois added a commit that referenced this issue Jan 23, 2018
@jgravois
# This is a combination of 4 commits.
ebc1ecb 
# The first commit's message is:
refactor(package.json files and rollup config): ensure JS build tools can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101

# This is the 2nd commit message:

travis needs sudo to install chrome now i guess

# This is the 3rd commit message:

leave the filenames be

# This is the 4th commit message:

i think its choking on the prepare script
jgravois added a commit that referenced this issue Jan 23, 2018
@jgravois
refactor(package.json files and rollup config): ensure JS build tools…
6baa9e1 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

ensure rollup doesnt use browser bundles

dont need sudo anymore
jgravois added a commit that referenced this issue Jan 23, 2018
@jgravois
refactor(package.json files and rollup config): ensure JS build tools…
2805225 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

ensure rollup doesnt use browser bundles

dont need sudo anymore
jgravois pushed a commit that referenced this issue Jan 23, 2018
@itrew @jgravois
Updated travis testing.
70ffc9d 
refactor(package.json files and rollup config): ensure JS build tools can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

ensure rollup doesnt use browser bundles

dont need sudo anymore
jgravois pushed a commit to jgravois/arcgis-rest-js that referenced this issue Jan 24, 2018
@itrew @jgravois
refactor(package.json files and rollup config): ensure JS build tools…
68ed614 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: Esri#101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

ensure rollup doesnt use browser bundles

dont need sudo anymore
jgravois added a commit that referenced this issue Jan 24, 2018
@jgravois
refactor(package.json files and rollup config): ensure JS build tools…
29e0189 
… can fetch a valid UMD file

and remove .umd from built filenames

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request

ISSUES CLOSED: #101

travis needs sudo to install chrome now i guess

leave the filenames be

i think its choking on the prepare script

another try with the npm@5 guess

ensure rollup doesnt use browser bundles

dont need sudo anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jluna @jgravois