Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should we be running lint before commits and in CI? #301

Closed
tomwayson opened this issue Aug 30, 2018 · 0 comments · Fixed by #313
Closed

should we be running lint before commits and in CI? #301

tomwayson opened this issue Aug 30, 2018 · 0 comments · Fixed by #313

Comments

@tomwayson
Copy link
Member

I think so.

Apparently we're not in CI:

arcgis-rest-js/package.json

Line 85 in f05ec37

"test:ci": "npm run test:node && npm run test:chrome:ci && npm run test:firefox",

Also, I see we've got husky as dev dep, but I don't see how it's configured.

I see 39 lint error when I run npm run lint at the root.
@tomwayson tomwayson mentioned this issue Aug 30, 2018
Closed
jgravois added a commit that referenced this issue Sep 11, 2018
@jgravois
chore(lint): make sure *all* the code is linted each commit
0374759 
AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-feature-service
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-request
@esri/arcgis-rest-sharing

ISSUES CLOSED: #301
@jgravois jgravois mentioned this issue Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lint): make sure *all* the code is linted each commit Esri/arcgis-rest-js
1 participant
@tomwayson