Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user app resources; tests use spyOn #1136

Closed
wants to merge 1 commit into from
Closed

Conversation

dbouwman
Copy link
Member

This adds functions for working with user app resources. These functions are copied from hub.js, along with the tests.

NOTE

The tests included use spyOn to create jasmine spies for request. This does not work in this project!

@dbouwman
Copy link
Member Author

dbouwman commented Dec 19, 2023

Main question here is: Can we use spies in here or must we mock all the calls? Hub is already using these fns, but to land in here we'd need to spend time changing the tests... which is hard to fit into my task list

Also - make sure we export the fns from the package

@dbouwman
Copy link
Member Author

Fundamentally, we can't use spies in rest-js b/c it's using typescript 3.9+, which marks module properties as read only, precluding the use of jasmine spies. In order to merge this, all the tests needs to be re-worked to use fetchMock. At this time none of us have bandwidth to tackle this. Closing.

@dbouwman dbouwman closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant