chore(changelog): prevent changelog.js from looking beyond newline for closed issues #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.js had some formatting issues in the 1.0.3 release (see https://github.com/Esri/arcgis-rest-js/blob/master/CHANGELOG.md#103---december-21st-2017)
This occurred because it pulled all text after
ISSUES CLOSED:and put it into the issue link. Commit 29e0189 was the one that caused the formatting issue because it had lots of text after the closed issues list.This PR makes changelog.js discard all text after the newline, so it only pulls the comma-separated issues.