-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set externals properly for UMD builds #129
Conversation
AFFECTS PACKAGES: @esri/arcgis-rest-auth @esri/arcgis-rest-common-types @esri/arcgis-rest-feature-service @esri/arcgis-rest-geocoder @esri/arcgis-rest-groups @esri/arcgis-rest-items @esri/arcgis-rest-request ISSUES CLOSED: #128
Demos that I've tested so far:
I think if we test one of the auth ones we can merge. I have to run, but will try that later. |
our only real auth demo uses Express (and consequently doesn't load UMDs, much like all said, nice catch @tomwayson and truly elegant fix @patrickarlt. i was stuck on the idea that we'd need to omit the package we actually wanted to bundle from the thinking about it more, your one liner makes sense because internally a package wouldn't include an import that referenced its own name. |
0d2ba98
to
c243cef
Compare
duh - forgot this repo did it's own CJS builds. so glad I tested ago-node-cli! thanks @jgravois |
Close #128.
@tomwayson @jgravois I did verify that this makes bundles smaller but you should verify that the demos still work. I probably inadvertently removed this while setting up the build system.