-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(npm packages): remove test files and tsconfig.json from npm tar… #133
Conversation
…balls AFFECTS PACKAGES: @esri/arcgis-rest-auth @esri/arcgis-rest-common-types @esri/arcgis-rest-feature-service @esri/arcgis-rest-geocoder @esri/arcgis-rest-groups @esri/arcgis-rest-items @esri/arcgis-rest-request ISSUES CLOSED: #132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgravois do we even need the src/**
files?
good question. @JeffJacobson (or any other TypeScript developer), is it sufficient when a lib you depend on only exposes ES6 modules and types and doesn't include raw https://unpkg.com/@esri/arcgis-rest-request@1.0.3/src/ |
I am far from a "TypeScript developer", but, FWIW, I have been including them in other TS projects like esri-loader, but I think that's a mistake. I'm almost certain that they are not needed because I say we drop |
@jgravois TypeScript uses the files under |
done and done. |
…balls
since we are distributing built types, UMDs, ES6 modules (with types) and common JS modules for node, it seems safe to remove the tsconfig.json entirely, especially since its incomplete.
there's no need to specify "README.md" or "package.json" or whatever is listed as "main". they are always included. this change drops the tests too to further shrink the bundles.
this will also solve problems like unintentionally shipping cruft like this:
https://unpkg.com/@esri/arcgis-rest-request@1.0.3/.rpt2_cache/
AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-common-types
@esri/arcgis-rest-feature-service
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-groups
@esri/arcgis-rest-items
@esri/arcgis-rest-request
ISSUES CLOSED: #132