Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CONTRIBUTING): add info about commitizen #167

Merged
merged 3 commits into from
Apr 5, 2018
Merged

chore(CONTRIBUTING): add info about commitizen #167

merged 3 commits into from
Apr 5, 2018

Conversation

jgravois
Copy link
Contributor

ISSUES CLOSED: #147

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8d3c695 on fix-147 into fd9005f on master.

@Esri Esri deleted a comment from coveralls Mar 30, 2018
CONTRIBUTING.md Outdated
* `npm run test:node:debug` run the node tests, automatically opening the Chrome debugger. This is great for debugging the tests while you are working. **REQUIRES CHROME 60+**. This also means you can do you really stupid things like run this in an infinite loop with `while :; do npm run test:node:debug; sleep 1; done` which will reopen the chrome debugger once the current one closes.

### Formatting commit messsages
Using [`npm run c`](https://github.com/Esri/arcgis-rest-js/blob/fd9005fef74c33c684273fd283aa6bd9990e8630/package.json#L110) (instead of `git commit`) create messages our handy [script](https://github.com/Esri/arcgis-rest-js/blob/master/support/changelog.js) can parse to categorize your bug fix, new feature or breaking change and associate it with relevant packages in our [CHANGELOG](CHANGELOG.mdv) automatically.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgravois Link to the changelog has a stray v appended to it.

@jgravois jgravois merged commit 9477de1 into master Apr 5, 2018
@jgravois jgravois deleted the fix-147 branch April 5, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants