-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UserSession.getCredential() #219
Conversation
@@ -510,6 +520,19 @@ export class UserSession implements IAuthenticationManager { | |||
}); | |||
} | |||
|
|||
// do we need to allow for passing a url? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet, so far we don't store multiple credentials.
@@ -510,6 +520,19 @@ export class UserSession implements IAuthenticationManager { | |||
}); | |||
} | |||
|
|||
// do we need to allow for passing a url? | |||
// trap for when session isnt fully hydrated? | |||
// should this return a promise? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - let the consuming app decide if the half baked credential is valid for their use case or not
9ce3aef
to
f1161db
Compare
tacked on another commit to use then rebased. |
AFFECTS PACKAGES: @esri/arcgis-rest-auth ISSUES CLOSED: #208
6bb8561
to
c03430d
Compare
first pass at #208
PRing against the
amd
branch for the sake of the demo.