Add a "headers" option to IRequestOptions #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass on the headers to the reque add a "headers" option to IRequestOptions. Optional headers are passed on to the request. When headers option is present in Node environments, it prevents the default referer header "@esri/arcgis-rest" from being set on the request. AFFECTS PACKAGES: @esri/arcgis-rest-request
dmfenton
reviewed
Jan 16, 2019
| if (typeof window === "undefined") { | ||
| if ( | ||
| typeof window === "undefined" && | ||
| requestOptions.headers === undefined |
There was a problem hiding this comment.
should we set the referrer when headers are passed-in but referer is still undefined?
There was a problem hiding this comment.
Ah, yeah, that's prob a good call
|
Closing this, now covered in #437 |
|
thanks for this contribution @rgwozdz 🌮:tada:! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following
adds a
headersoption to IRequestOptions. Optional headers are passed on to the target request.in Node environments, the presence of the
headersoptions prevents the defaultrefererheader"@esri/arcgis-rest"from being set on the request. If arefereris desired, it can be set with the header option.I have found that (2) is critical in a particular case; ArcGIS search service sometimes rejects a request with a valid token when the
refereris set to"@esri/arcgis-rest". (Note that in such cases, ArcGIS search returns a498 Invalid tokenresponse; but stripping the referer header from the request results in a success response, which indicates the problem is not with the token.)