fix: allow org admins to modify group sharing of public items outside the org #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation AFFECTS PACKAGES: @esri/arcgis-rest-sharing ISSUES CLOSED: 454
dbouwman
approved these changes
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 94 94
Lines 1170 1170
Branches 209 209
=====================================
Hits 1170 1170
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org admins can indeed use Share Item (as Group Admin) to share a public item outside their organization with a private group inside their org.
this is true even if they are not a group member/admin.
AFFECTS PACKAGES:
@esri/arcgis-rest-sharing
ISSUES CLOSED: #454