Dev summit 2019 demos

[patrickarlt]

No description provided.

[codecov]

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #481   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines        1214   1214           
  Branches      225    225           
=====================================
  Hits         1214   1214

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ad63d...ec20da5. Read the comment docs.

[jgravois]

i pushed up a few copyedits, but in general, these look great.

the CLI app ran on my machine fine, but i encountered an error trying to run the sapper app. any ideas?

john6251 at Frink in ~/github/arcgis-rest-js/demos/webmap-checker-sapper on pa-dev-summit-2019-demos [!]
$ npm run dev

> sapper-webmap-checker@1.17.1 dev /Users/john6251/github/arcgis-rest-js/demos/webmap-checker-sapper
> sapper dev

• server
'request' is imported from external module '@esri/arcgis-rest-request' but never used
'loadModules' and 'loadCss' are imported from external module 'esri-loader' but never used
✔ client (1.1s)
✔ service worker (20ms)
Thu, 07 Mar 2019 18:06:35 GMT express-session deprecated req.secret; provide secret option at __sapper__/dev/server/server.js:3389:5
> Listening on http://localhost:3000
Error: secret option required for sessions
    at session (/Users/john6251/github/arcgis-rest-js/demos/webmap-checker-sapper/node_modules/express-session/index.js:199:12)
    at Layer.handle [as handle_request] (/Users/john6251/github/arcgis-rest-js/demos/webmap-checker-sapper/node_modules/express/lib/router/layer.js:95:5)

[patrickarlt]

@jgravois I've updated the read me for the sapper demo to explain the config which was git ignored. I also added a bunch of doc explaining auth. I also updated the code a bit and added some more comments.

[jgravois]

awesome @patrickarlt! i just pushed up a few more typo fixes of my own.

it took me a couple minutes to figure out, but i had to remove the trailing slash from the redirect URI you were suggesting in the README in order to resolve the route that Sapper is creating on the fly from post-sign-in.js.

REDIRECT_URI=http://localhost:3000/auth/post-sign-in