Fix issues with path being lowercased during federation #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 93 93
Lines 1361 1366 +5
Branches 245 245
=====================================
+ Hits 1361 1366 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomwayson @dbouwman I ran into an issue today were a path to an ArcGIS Server instance had uppercase characters in it and it cased an error when the whole URL was lowercased. Since there were previous cases which stated a domain should be lowercased #417 I split all this functionality out into its own function and added specific tests for it.