Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcgis-rest-feature-layer - geometry not getting passed in to queryFeatures #592

Merged
merged 2 commits into from
Jul 3, 2019
Merged

arcgis-rest-feature-layer - geometry not getting passed in to queryFeatures #592

merged 2 commits into from
Jul 3, 2019

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Jun 25, 2019

if you pass in any of the following properties they do not get passed through the query:

  • geometry
  • geometryType
  • spatialRel

Adding a unit test to illustrate the issue

test to check if geometry and related params are getting passed through the queryFeatures function
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #592   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines        1407   1407           
  Branches      248    248           
=====================================
  Hits         1407   1407
Impacted Files Coverage Δ
packages/arcgis-rest-feature-layer/src/query.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b956d91...847d81d. Read the comment docs.

@gavinr gavinr marked this pull request as ready for review June 25, 2019 15:50
@gavinr gavinr requested a review from tomwayson June 25, 2019 15:51
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @gavinr!

Sorry it's taken so long to review.

Would you mind running npm run c to get a well formatted commit message that can be used to generate the changelog for this?

I promise a speedy merge and release turn around after ^^^.

@tomwayson
Copy link
Member

Actually, nvm, I'll do that after merging and fixing #589

@tomwayson
Copy link
Member

@gavinr - this was released in v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants