-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arcgis-rest-feature-layer - geometry not getting passed in to queryFeatures #592
arcgis-rest-feature-layer - geometry not getting passed in to queryFeatures #592
Conversation
test to check if geometry and related params are getting passed through the queryFeatures function
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 95 95
Lines 1407 1407
Branches 248 248
=====================================
Hits 1407 1407
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @gavinr!
Sorry it's taken so long to review.
Would you mind running npm run c
to get a well formatted commit message that can be used to generate the changelog for this?
I promise a speedy merge and release turn around after ^^^.
Actually, nvm, I'll do that after merging and fixing #589 |
@gavinr - this was released in v2.1.1 |
if you pass in any of the following properties they do not get passed through the query:
geometry
geometryType
spatialRel
Adding a unit test to illustrate the issue