Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore trailing slashes in server url #605

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Conversation

green3g
Copy link
Contributor

@green3g green3g commented Jul 26, 2019

Prevent issues with authenticating with standalone server url's that contain trailing slashes

#604

Prevent issues with authenticating with standalone server url's that contain trailing slashes
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #605   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          96     96           
  Lines        1448   1448           
  Branches      253    253           
=====================================
  Hits         1448   1448
Impacted Files Coverage Δ
packages/arcgis-rest-auth/src/UserSession.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0768eab...e005ea0. Read the comment docs.

@patrickarlt patrickarlt self-requested a review August 6, 2019 21:31
Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging. Thanks @roemhildtg!

@patrickarlt patrickarlt merged commit 1635eb2 into Esri:master Aug 7, 2019
@tomwayson
Copy link
Member

Thank you @roemhildtg! released in 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants