Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arcgis-rest-portal): use deleteRelationship not removeRelationship #740

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

dbouwman
Copy link
Member

Previous implementation used non-existant /removeRelationship end-point.
Changed to the correct /deleteRelationship url

AFFECTS PACKAGES:
@esri/arcgis-rest-portal

ISSUES CLOSED: #739

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #740 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #740   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       112           
  Lines         1721      1721           
  Branches       303       303           
=========================================
  Hits          1721      1721           
Impacted Files Coverage Δ
packages/arcgis-rest-portal/src/items/remove.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac3ab2...890e485. Read the comment docs.

Previous implementation used non-existant /removeRelationship end-point. Changed to the correct
/deleteRelationship url

AFFECTS PACKAGES:
@esri/arcgis-rest-portal

ISSUES CLOSED: #739
@dbouwman dbouwman force-pushed the b/739-use-deleteRelationship branch from 2772cee to 890e485 Compare August 31, 2020 20:42
@dbouwman dbouwman merged commit b3368f9 into master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removeItemRelationship is not working
3 participants