review fixes

Esri · Dec 12, 2024 · 4e384e5 · 4e384e5
1 parent 4614b26
commit 4e384e5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/...es/calcite-components/src/components/autocomplete-item-group/autocomplete-item-group.scss b/...es/calcite-components/src/components/autocomplete-item-group/autocomplete-item-group.scss
@@ -10,20 +10,17 @@
 
 .scale--s {
   @apply text-n2h;
-  --calcite-internal-autocomplete-item-group-spacing-unit-l: theme("spacing.2");
-  --calcite-internal-autocomplete-item-group-spacing-unit-s: theme("spacing.2");
+  --calcite-internal-autocomplete-item-group-spacing-unit: theme("spacing.2");
 }
 
 .scale--m {
   @apply text-n1h;
-  --calcite-internal-autocomplete-item-group-spacing-unit-l: theme("spacing.3");
-  --calcite-internal-autocomplete-item-group-spacing-unit-s: theme("spacing.3");
+  --calcite-internal-autocomplete-item-group-spacing-unit: theme("spacing.3");
 }
 
 .scale--l {
   @apply text-0h;
-  --calcite-internal-autocomplete-item-group-spacing-unit-l: theme("spacing.4");
-  --calcite-internal-autocomplete-item-group-spacing-unit-s: theme("spacing.4");
+  --calcite-internal-autocomplete-item-group-spacing-unit: theme("spacing.4");
 }
 
 :host {
@@ -36,7 +33,7 @@
   @apply flex
     flex-col;
   background-color: var(--calcite-autocomplete-background-color, var(--calcite-color-foreground-1));
-  padding-block-start: var(--calcite-internal-autocomplete-item-group-spacing-unit-l);
+  padding-block-start: var(--calcite-internal-autocomplete-item-group-spacing-unit);
 }
 
 .container--no-spacing {
@@ -54,8 +51,8 @@
     font-bold;
   color: var(--calcite-autocomplete-text-color, var(--calcite-color-text-2));
   border-block-end-color: var(--calcite-autocomplete-border-color, var(--calcite-color-border-3));
-  padding-block: var(--calcite-internal-autocomplete-item-group-spacing-unit-l);
-  padding-inline: var(--calcite-internal-autocomplete-item-group-spacing-unit-s);
+  padding-block: var(--calcite-internal-autocomplete-item-group-spacing-unit);
+  padding-inline: var(--calcite-internal-autocomplete-item-group-spacing-unit);
 }
 
 @include base-component();
diff --git a/...ges/calcite-components/src/components/autocomplete-item-group/autocomplete-item-group.tsx b/...ges/calcite-components/src/components/autocomplete-item-group/autocomplete-item-group.tsx
@@ -30,10 +30,14 @@ export class AutocompleteItemGroup extends LitElement {
    */
   @property() disableSpacing = false;
 
-  /** The component's text. */
+  /**
+   * Specifies heading text for the component.
+   *
+   * @required
+   */
   @property() heading: string;
 
-  /** The component's label. */
+  /** Accessible name for the component. */
   @property() label: any;
 
   /**

diff --git a/packages/calcite-components/src/components/autocomplete-item/autocomplete-item.tsx b/packages/calcite-components/src/components/autocomplete-item/autocomplete-item.tsx
@@ -58,7 +58,11 @@ export class AutocompleteItem
    */
   @property() guid = `autocomplete-item-${guid()}`;
 
-  /** Specifies heading text for the component. */
+  /**
+   * Specifies heading text for the component.
+   *
+   * @required
+   */
   @property() heading: string;
 
   /** Specifies an icon to display at the end of the component. */