Skip to content

Commit

Permalink
ci(provenance): add missing options from setup doc (#9433)
Browse files Browse the repository at this point in the history
**Related Issue:** #9429

## Summary

Update the deployment GitHub Actions according to steps in the [npm
provenance
doc](https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions),
which I missed because I was looking at the 3rd party section below it.

The [GitHub provenance
doc](https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry)
doesn't mention permissions, so it might not be required.

We had originally hardcoded an older version of Ubuntu in #5942 due to
errors, but it was resolved in Stencil v4.
  • Loading branch information
benelan authored May 29, 2024
1 parent a13b0e6 commit b390cd4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/deploy-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ permissions:
pull-requests: write
jobs:
release-please:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- uses: google-github-actions/release-please-action@v3.7.13
id: release
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/deploy-next.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ on:
branches: [main]
jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- uses: actions/checkout@v4
with:
Expand Down

0 comments on commit b390cd4

Please sign in to comment.