Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable console warnings #10038

Open
2 of 6 tasks
maxpatiiuk opened this issue Aug 12, 2024 · 2 comments
Open
2 of 6 tasks

Add a way to disable console warnings #10038

maxpatiiuk opened this issue Aug 12, 2024 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate.

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Aug 12, 2024

Check existing issues

Description

#9739 added console messages for current calcite version. These are useful in production for ensuring calcite is not loaded twice.

However, these console messages are adding noise in development. In e2e tests, it's even worse since the message is logged for each test file:

image

Acceptance Criteria

  1. A way to disable the console warnings when they are not necessary. For example, Lit package refers to this set on the global to decide whether warning should be emitted - https://github.com/lit/lit/blob/619449b84cb63d9c00e4316551246957c939a64b/packages/reactive-element/src/reactive-element.ts#L83-L85 - an app can define that set before importing Lit to supress the warning
  2. Have Calcite ship separate production and dev mode bundles, with dev only checks in the dev bundle and production only checks in the production bundle. For example, how Lit has this configured: https://github.com/lit/lit/blob/619449b84cb63d9c00e4316551246957c939a64b/packages/reactive-element/package.json#L22-L25

Relevant Info

No response

Which Component

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@maxpatiiuk maxpatiiuk added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 12, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 12, 2024
@jcfranco
Copy link
Member

Blocked by #10310.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Sep 27, 2024
@geospatialem geospatialem added this to the Stalled milestone Sep 27, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Sep 27, 2024
Copy link
Contributor

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@github-actions github-actions bot removed the blocked This issue is blocked by another issue. label Nov 26, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 26, 2024
@geospatialem geospatialem removed this from the Stalled milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate.
Projects
None yet
Development

No branches or pull requests

3 participants