Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] No line height defined for heading or description #10042

Closed
2 of 6 tasks
macandcheese opened this issue Aug 12, 2024 · 2 comments
Closed
2 of 6 tasks

[Panel] No line height defined for heading or description #10042

macandcheese opened this issue Aug 12, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-08-27 - Aug ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 12, 2024 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

The heading and description text has no defined line height and can be overridden unexpectedly - we should explicitly set line heights to prevent this.

Expected Behavior

I'd expect styles within the component to be set that prevent outside css from affecting the styles. We should confirm appropriate styles are set on any other slots or rendered elements as well.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/zYVPvKE?editors=1000

Reproduction Steps

  1. Open codepen

Reproduction Version

2.11

Relevant Info

No response

Regression?

2.10 - https://github.com/Esri/calcite-design-system/pull/9730/files#diff-0b45120ffa61191421f1699207bb91da11d979e0a76a1b28d50353a3b17394c2

Priority impact

impact - p1 - need for current milestone

Impact

This will affect any apps that have line height defined in external css, most notably jsapi css which causes unwanted style changes when used with 2.11

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Aug 12, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Aug 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 12, 2024
@jcfranco jcfranco added this to the 2024-08-27 - Aug Release milestone Aug 12, 2024
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 16, 2024
@Elijbet Elijbet mentioned this issue Aug 16, 2024
Merged
Elijbet added a commit that referenced this issue Aug 16, 2024
@Elijbet
fix(panel): define heading and description line height (#10085)
5478eb9 
**Related Issue:** #10042

## Summary
Fix regression where panel `heading` and `description` retain their line
height.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Aug 19, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 20, 2024

🍡 Verified on 2.12.0-next.26

@DitwanP DitwanP closed this as completed Aug 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
5 participants
@jcfranco @macandcheese @geospatialem @Elijbet @DitwanP