Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inconsistent shadow styles with new shadow tokens #10050

Open
1 of 14 tasks
rmstinson opened this issue Aug 13, 2024 · 7 comments
Open
1 of 14 tasks

Replace inconsistent shadow styles with new shadow tokens #10050

rmstinson opened this issue Aug 13, 2024 · 7 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.

Comments

@rmstinson
Copy link

rmstinson commented Aug 13, 2024

Check existing issues

Blocked issues: #9758

Description

A handful of Calcite components use a different shadow style than the tailwind style shadow.2. Most of them currently use the style "0 0 16px 0 rgba(0, 0, 0, 0.16)." Some are inheriting the style from the classes "calcite-floating-ui-anim" + "calcite-floating-ui-anim--active." Those components' shadow styles need to be replaced with shadow.2 in the code.

Acceptance Criteria

  • Ensure the opacities used in shadow tokens are set in core

    • 0.04
    • 0.08
    • 0.10
    • 0.12
    • 0.16
  • Add new semantic black color tokens for use with shadows:

    • color.shadow.1
      • light mode: rgba({core.color.neutral.blk-240}, {core.opacity.04})
      • dark mode: rgba({core.color.neutral.blk-240}, {core.opacity.12})
    • color.shadow.2
      • light mode: rgba({core.color.neutral.blk-240}, {core.opacity.08})
      • darkmode: rgba({core.color.neutral.blk-240}, {core.opacity.12})
    • color.shadow.3
      • light mode: rgba({core.color.neutral.blk-240}, {core.opacity.10})
      • dark mode: rgba({core.color.neutral.blk-240}, {core.opacity.16})
  • Add new semantic shadow tokens:

    • shadow.sm = box-shadow: 0px 2px 8px 0px {semantic.color.shadow.3}, 0px 2px 8px 0px {semantic.color.shadow.1};
    • shadow.md = box-shadow: 0px 6px 20px -4px {semantic.color.shadow.3}, 0px 4px 12px -2px {semantic.color.shadow.2};
  • Apply shadow tokens as listed in Which Component section below.

Relevant Info

Figma spec reference

Image
Image

Which Component

shadow.sm

  • Notice
  • Sheet
  • Shell Panel display-mode=“float-all” | “float-content” | “overlay”

shadow.md

  • Action Menu (renders a Popover)
  • Action Pad
  • Alert
  • Autocomplete
  • Dialog
  • Dropdown
  • FAB
  • Combobox / Input Time Zone
  • Input Date Picker
  • Input Time Picker
  • Menu Item (horizontal submenus)
  • Popover
  • Tooltip

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@rmstinson rmstinson added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 13, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-angular calcite-components-react Issues specific to the @esri/calcite-components-react package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. labels Aug 13, 2024
@rmstinson rmstinson self-assigned this Aug 13, 2024
@github-actions github-actions bot added the impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone label Aug 13, 2024
@SkyeSeitz SkyeSeitz changed the title Replace non-tailwind shadow styles with shadow.1 / shadow.2 tailwind styles for existing components Replace inconsistent shadow styles with shadow.2 for existing components Aug 15, 2024
@macandcheese
Copy link
Contributor

Note: Shell Panel also has similar bespoke values for "directional" shadows based on "overlay" displayMode and Shell Panel placement.

@anveshmekala
Copy link
Contributor

date-picker uses a custom value here when day is focused. Does this qualify for a new core token?

@ashetland
Copy link
Contributor

@anveshmekala Is that box-shadow needed? Button also uses an outset focus and does not do this.

@ashetland ashetland self-assigned this Feb 4, 2025
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library and removed 0 - new New issues that need assignment. labels Feb 4, 2025
@ashetland ashetland added design Issues that need design consultation prior to development. and removed needs triage Planning workflow - pending design/dev review. labels Feb 4, 2025
@ashetland ashetland changed the title Replace inconsistent shadow styles with shadow.2 for existing components Replace inconsistent shadow styles with new shadow tokens Feb 10, 2025
@ashetland
Copy link
Contributor

Updated issue title and description and marking ready for dev. cc @matgalla @alisonailea

@ashetland ashetland added the ready for dev Issues ready for development implementation. label Feb 10, 2025
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 10, 2025
Copy link
Contributor

cc @geospatialem, @brittneytewks

@alisonailea
Copy link
Contributor

Updated issue title and description and marking ready for dev. cc @matgalla @alisonailea

Updated issue description with additional Token Studio references

@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 18, 2025
@ashetland
Copy link
Contributor

@geospatialem, I'm assigning this to @matgalla for the initial tokens effort. The last item will need to be picked up once Matt's work is complete.

@ashetland ashetland added the design-tokens Issues requiring design tokens. label Feb 19, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

9 participants