Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-time-zone): ensure beforeOpen/open and beforeClose/close events emit properly #10228

Merged
merged 5 commits into from
Sep 7, 2024
Merged

fix(input-time-zone): ensure beforeOpen/open and beforeClose/close events emit properly #10228

merged 5 commits into from
Sep 7, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Sep 5, 2024 •
edited
Loading

Related Issue: #9315, #10227

Summary

This addresses some issues that prevented beforeOpen/open and beforeClose/close events from emitting as expected.

Notes

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Sep 5, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Sep 5, 2024
@jcfranco jcfranco mentioned this pull request Sep 5, 2024
Open
@jcfranco jcfranco requested a review from Elijbet September 6, 2024 22:55
@jcfranco jcfranco changed the title fix(input-time-zone): fix duplicate open/close event emitting fix(input-time-zone): ensure beforeOpen/open and beforeClose/close events emit properly Sep 6, 2024
@jcfranco jcfranco marked this pull request as ready for review September 6, 2024 23:44
@jcfranco jcfranco requested a review from driskull September 6, 2024 23:46
driskull
driskull approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/calcite-components/src/components/input-time-zone/input-time-zone.tsx
@@ -487,6 +493,7 @@ export class InputTimeZone
componentDidLoad(): void {
setComponentLoaded(this);
this.overrideSelectedLabelForRegion(this.open);
this.openChanged();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, i'm wondering if its better to call this when there's a ref for the element rather than in componentDidLoad?

I'm not sure it makes a difference in most cases but it just seems more appropriate?

In this case it would be in setComboboxRef

@jcfranco jcfranco merged commit 3f04a0b into dev Sep 7, 2024
15 checks passed
@jcfranco jcfranco deleted the jcfranco/9315-fix-extra-input-time-zone-open-close-events branch September 7, 2024 07:27
@github-actions github-actions bot added this to the 2.12.2 patch milestone Sep 7, 2024
jcfranco added a commit that referenced this pull request Sep 9, 2024
@jcfranco
test(input-time-picker): skip unstable test (#10245)
f8bb879 
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
benelan pushed a commit that referenced this pull request Sep 9, 2024
@jcfranco @benelan
fix(input-time-zone): ensure beforeOpen/open and beforeClose/`c…
ca1fbc1 
…lose` events emit properly (#10228)
benelan pushed a commit that referenced this pull request Sep 9, 2024
@jcfranco @benelan
test(input-time-picker): skip unstable test (#10245)
343171f 
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
benelan pushed a commit that referenced this pull request Sep 9, 2024
@jcfranco @benelan
fix(input-time-zone): ensure beforeOpen/open and beforeClose/`c…
71423cb 
…lose` events emit properly (#10228)
benelan pushed a commit that referenced this pull request Sep 9, 2024
@jcfranco @benelan
test(input-time-picker): skip unstable test (#10245)
0faffa3 
**Related Issue:** #10227

## Summary

Re-skip unstable test (see #10226).

Unfortunately, #10228
didn't stabilize this test.
@benelan benelan mentioned this pull request Sep 9, 2024
Merged
benelan added a commit that referenced this pull request Sep 9, 2024
@benelan
chore: release main (#10254)
64c9d4c 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.12.2</summary>

##
[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2)
(2024-09-09)


### Bug Fixes

* **input-time-zone:** Ensure `beforeOpen`/`open` and
`beforeClose`/`close` events emit properly
([#10228](#10228))
([71423cb](71423cb))
* **panel, flow-item:** Hide focus-outline when scrolling via mouse to
align with browsers
([#10242](#10242))
([7a8cb72](7a8cb72))
* **shell:** Fix z-index of shell-panels
([#10224](#10224))
([36d51b6](36d51b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.12.2</summary>

##
[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2)
(2024-09-09)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

<details><summary>@esri/calcite-components-react: 2.12.2</summary>

##
[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2)
(2024-09-09)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan added a commit that referenced this pull request Sep 9, 2024
@benelan
chore: release main (#10254)
334c854 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.12.2</summary>

[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2)
(2024-09-09)

* **input-time-zone:** Ensure `beforeOpen`/`open` and
`beforeClose`/`close` events emit properly
([#10228](#10228))
([71423cb](71423cb))
* **panel, flow-item:** Hide focus-outline when scrolling via mouse to
align with browsers
([#10242](#10242))
([7a8cb72](7a8cb72))
* **shell:** Fix z-index of shell-panels
([#10224](#10224))
([36d51b6](36d51b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.12.2</summary>

[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2)
(2024-09-09)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

<details><summary>@esri/calcite-components-react: 2.12.2</summary>

[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2)
(2024-09-09)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request Sep 9, 2024
Merged
benelan added a commit that referenced this pull request Sep 9, 2024
@benelan
chore: release main (#10254)
718d35b 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.12.2</summary>


[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.1...@esri/calcite-components@2.12.2)
(2024-09-09)

* **input-time-zone:** Ensure `beforeOpen`/`open` and
`beforeClose`/`close` events emit properly
([#10228](#10228))

([71423cb](71423cb))
* **panel, flow-item:** Hide focus-outline when scrolling via mouse to
align with browsers
([#10242](#10242))

([7a8cb72](7a8cb72))
* **shell:** Fix z-index of shell-panels
([#10224](#10224))

([36d51b6](36d51b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.12.2</summary>


[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.1...@esri/calcite-components-angular@2.12.2)
(2024-09-09)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

<details><summary>@esri/calcite-components-react: 2.12.2</summary>


[2.12.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.1...@esri/calcite-components-react@2.12.2)
(2024-09-09)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.12.1 to 2.12.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).
@calcite-admin calcite-admin mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@Elijbet Elijbet Awaiting requested review from Elijbet

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2.12.2 patch
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull