Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] potentially unintentional property name collision #10235

Closed
1 of 5 tasks
maxpatiiuk opened this issue Sep 6, 2024 · 2 comments
Closed
1 of 5 tasks

[Slider] potentially unintentional property name collision #10235

maxpatiiuk opened this issue Sep 6, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-09-30 - 2.13...

Comments

@maxpatiiuk
Copy link
Member

Description

HTMLElement has a "translate" boolean property
slider.tsx has a "translate" private method
This collision is potentially unintentional - could you rename the private method?

Proposed Advantages

Avoids collision

Which Component

slider

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@maxpatiiuk maxpatiiuk added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. labels Sep 6, 2024
@maxpatiiuk maxpatiiuk changed the title Potentially unintentional property name collision [Slider] potentially unintentional property name collision Sep 6, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 12, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed estimate - 3 A day or two of work, likely requires updates to tests. 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 12, 2024
@jcfranco jcfranco mentioned this issue Sep 12, 2024
Merged
jcfranco added a commit that referenced this issue Sep 13, 2024
@jcfranco
refactor(slider): rename internal function to avoid collision with `H…
Loading
Loading status checks…
e52524b 
…TMLElement.translate` (#10293)

**Related Issue:** #10235

## Summary

[`HTMLElement.translate`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/translate)
is a newly available baseline property, so this renames an existing
function to avoid any conflicts.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned jcfranco Sep 13, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Sep 13, 2024

🍡 Verified

@DitwanP DitwanP closed this as completed Sep 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP