Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Action Pad] Horizontal action groups do not align #10307

Closed
1 of 6 tasks
mpayson opened this issue Sep 13, 2024 · 4 comments
Closed
1 of 6 tasks

[Action Pad] Horizontal action groups do not align #10307

mpayson opened this issue Sep 13, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-09-30 - 2.13...

Comments

@mpayson
Copy link

mpayson commented Sep 13, 2024

Check existing issues

Actual Behavior

Action pad groups are slightly unaligned
Screenshot 2024-09-13 at 3 38 08 PM

Expected Behavior

Action pad groups are aligned

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/action-pad/

Reproduction Steps

  1. Go to sample
  2. Change to "Action Pad with groups"
  3. Change to horizontal layout
  4. See issue

Reproduction Version

2.12.2

Relevant Info

No response

Regression?

2.11

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2024
@github-actions github-actions bot added the impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone label Sep 13, 2024
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Sep 13, 2024
@geospatialem
Copy link
Member

Potentially related to #10058

@alisonailea
Copy link
Contributor

alisonailea commented Sep 19, 2024 •
edited
Loading

Issue identified. There is an extra border-block-end. PR incoming.

@alisonailea alisonailea mentioned this issue Sep 19, 2024
Merged
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 19, 2024
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 19, 2024
geospatialem pushed a commit that referenced this issue Sep 25, 2024
@alisonailea
fix(action-pad): fix horizontal action group alignment (#10359)
7b03745 
**Related Issue:** #10307

## Summary

Removes an extra border-block-end which was causing a layout bug
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 25, 2024
@geospatialem
Copy link
Member

Verified with Chromatic build:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
4 participants
@alisonailea @geospatialem @mpayson @DitwanP