Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sheet] Add support for non-modal Sheet, other improvements #10364

Closed
2 of 6 tasks
macandcheese opened this issue Sep 20, 2024 · 1 comment
Closed
2 of 6 tasks

[Sheet] Add support for non-modal Sheet, other improvements #10364

macandcheese opened this issue Sep 20, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
Design Backlog

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Sep 20, 2024 •
edited
Loading

Check existing issues

Description

Placeholder issue for a set of enhancements to improve the Sheet component. This will support more use-cases and improve consistency with the Dialog component.

Rendering a Panel inside Sheet will provide an enhanced developer experience as well as ensure visual similarity in implementations.

Acceptance Criteria

  • Sheet renders Panel to match Dialog, passing through appropriate slots + properties.
  • Sheet adds nonmodal display by default (breaking change) to match Dialog
  • Keeps the "overlay / float" display types
  • Resizability is added to Sheet - using an updated affordance with generous hit area to support the thumb gestures / mobile behavior that is common + expected with these displays (design to discuss: swipe tolerances for min / max height (or width), swipe tolerance for close, etc). Note that this doesn't apply just to mobile viewport sizes - these are needed behaviors in larger environments as well.

Relevant Info

cc @SkyeSeitz @ashetland for ui / ux discussion + final properties / slots needed from a design perspective.

Which Component

Sheet

Example Use Case

As a designer-user - I want to use a nonmodal Sheet, and have the visual display match Dialog and other components

As a developer-user - I want to build the component in a similar manner to Dialog, and simplify the need to manage properties with my own slotted Panel inside Sheet

As an end-user - I want to use common mobile "niceties", like large hit areas for thumb dragging, and swipe interactions.

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. labels Sep 20, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Sep 20, 2024
@ashetland ashetland added the design Issues that need design consultation prior to development. label Sep 20, 2024
@driskull driskull mentioned this issue Oct 23, 2024
Merged
@ashetland ashetland added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - design - sm Small design effort; 1-4 days of design work labels Nov 14, 2024
@ashetland ashetland added this to the Design Backlog milestone Nov 14, 2024
@ashetland ashetland removed the needs triage Planning workflow - pending design/dev review. label Nov 14, 2024
@ashetland
Copy link
Contributor

This is covered in issues #7591, #9828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
Design Backlog
Development

No branches or pull requests
2 participants
@macandcheese @ashetland