Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sheet] Add resizable functionality #7591

Closed
2 of 3 tasks
macandcheese opened this issue Aug 24, 2023 · 11 comments
Closed
2 of 3 tasks

[Sheet] Add resizable functionality #7591

macandcheese opened this issue Aug 24, 2023 · 11 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-12-17 - Dec ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 24, 2023 •
edited
Loading

Check existing issues

Description

Follow-up issue to add resizable functionality to Sheet.
Should coincide with / follow #5652
May require updates to the default min / max width css var set here, Shell Panel, for consistency.

Acceptance Criteria

Resizable functionality is added to Sheet.

Relevant Info

cc @driskull

Which Component

Sheet

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 24, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Aug 24, 2023
@macandcheese
Copy link
Contributor Author

+1 from BA cc @ddred11

@macandcheese macandcheese added the p - medium Issue is non core or affecting less that 60% of people using the library label Oct 30, 2023
@SkyeSeitz SkyeSeitz added design Issues that need design consultation prior to development. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Oct 30, 2023
@brittneytewks brittneytewks removed the needs triage Planning workflow - pending design/dev review. label Oct 30, 2023
@brittneytewks brittneytewks added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 30, 2023
@SkyeSeitz SkyeSeitz added the estimate - design - md Medium design effort; 5-10 days of design work label Oct 30, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@brittneytewks
Copy link

Removed Figma changes label as this will be tracked in monday.com

@geospatialem
Copy link
Member

This effort should either be combined or added after #5652 to add shell-panel improvements to the resizable functionality, for the drag handle addordance and to support resizing for when the displayMode is "float".

@geospatialem geospatialem modified the milestones: 2024-01-17 - Jan Main Release, 2024-01-19 - Jan Maintenance Release, 2024-02-27 - Feb Maintenance Release Jan 17, 2024
@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Jan 18, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@driskull driskull self-assigned this Sep 9, 2024
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 9, 2024
@driskull
Copy link
Member

@SkyeSeitz @ashetland do we need an element drag handle in the designs? I'm just wondering if there is a good enough reason to have a resize element which would take up more space? Even in Figma the Figma side panels are resizable but there isn't a resize handle. My concern is taking more space away from content and if it is worth it. I just want to make sure there is a need for this.

For dialog, we do not have resize handles even when a dialog is resizable. It would probably look pretty odd with them on all sides as well.

driskull added a commit that referenced this issue Oct 10, 2024
@driskull
feat(sheet): add resizable property. #7591
8b1f76a
@driskull driskull mentioned this issue Oct 10, 2024
Merged
@driskull
Copy link
Member

@SkyeSeitz @ashetland is there an issue for tracking the new drag icon shown in Figma? Will that icon be available for the oct release or do we want to either push this or roll without the icon for this release?

@SkyeSeitz
Copy link

SkyeSeitz commented Oct 10, 2024 •
edited
Loading

A request has been submitted and the hope is it will be ready for the release 🤞 Will keep the team updated on status and final name of the icon per icon team decision.

@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 11, 2024
@SkyeSeitz
Copy link

drag-resize icons have landed https://github.com/Esri/calcite-design-system/pull/10553/files @driskull

@ashetland ashetland mentioned this issue Nov 14, 2024
Closed
6 tasks
driskull added a commit that referenced this issue Dec 12, 2024
@driskull
feat(sheet): add resizable property (#10521)
927eef5 
**Related Issue:** #7591

## Summary

- adds resize functionality
- adds assistive text live region for keyboard instructions
- adds tests
- updates story
- adds dom utility
- adds t9n files
- use new resize icon
- uses separator role, related to #3535
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 12, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Dec 12, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
6 participants
@driskull @macandcheese @geospatialem @SkyeSeitz @DitwanP @brittneytewks