Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell Panel] Improve visibility of resizable functionality, allow resizable when displayMode="float" #5652

Open
2 tasks done
macandcheese opened this issue Oct 26, 2022 · 6 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Oct 26, 2022

Description

The current drag handle affordance can be a bit hard to notice.
This should support both Shell Panel and upcoming Sheet implementations.

Acceptance Criteria

  • The resizable functionality of Shell Panel is easier to notice. This should also in certain cases be visually large enough (or have a hitbox large enough) to support thumb gestures for dragging.
  • Support resizable when the component is also detached, when displayMode is set to "float"

Relevant Info

Questions:

  • Should this have a "click to collapse" and "click to expand" button - brought up as UC feedback?

Which Component

Shell Panel, Sheet (upcoming)

Example Use Case

cc @asangma @SkyeSeitz @ashetland

Esri team

Calcite (design)

Calcite Design Solution

image

🔗 Link to Figma Specs

@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 26, 2022
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Oct 26, 2022
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Mar 20, 2023
@macandcheese
Copy link
Contributor Author

cc @SkyeSeitz @ashetland

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Jun 1, 2023
@geospatialem geospatialem added this to the Design Backlog milestone Jun 1, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 1, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@macandcheese
Copy link
Contributor Author

+1 from BA cc @ddred11

@macandcheese macandcheese added the p - medium Issue is non core or affecting less that 60% of people using the library label Oct 30, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 11, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 19, 2023
@SkyeSeitz SkyeSeitz added estimate - 8 Requires input from team, consider smaller steps. estimate - 5 A few days of work, definitely requires updates to tests. and removed estimate - 8 Requires input from team, consider smaller steps. labels Jan 2, 2024
@geospatialem geospatialem removed this from the 2024-01-17 - Jan Main Release milestone Jan 17, 2024
@COV-GIS
Copy link

COV-GIS commented Mar 14, 2024

I had been working my own footer component with resizing until it was brought to my attention a shell-panel works better and has resizing built in. At first I thought resizing wasn't working. I couldn't see the drag bar and when I did it was real hard to use on a large hi-res screen. And it isn't intuitive to the user there's resizing even if they notice the bar.

Overall I like how it works, looks and fits the "calcite design" well. It would fine by me if it was 1 or 2 px bigger, had an additional 5px of hitbox either side, and had some indication of draggability. Methinks having a brand colored portion of the bar in the center when not active would look good and clearly indicate draggability.

Here was my solution as an example.

image

Also +1 on a collapse/expand button.

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@macandcheese macandcheese changed the title [Shell Panel] Improve visibility of resizable functionality [Shell Panel] Improve visibility of resizable functionality, allow resizable when displayMode="float" Jun 7, 2024
@driskull
Copy link
Member

questions:

  • There's no collapse button in the design right? I'm not seeing one. I just see double click to collapse/expand.

Some comments:

  • We can maybe remove the need for the separator element to be focusable/focused for keyboard interactivity. Arrow keys when the panel is focused should just be able to handle this but would require an aria-live region to announce this.
  • We can potentially use interact.js to handle resizing for better UX/consistency.
  • I'm not sure the hit box area is really an issue. All other resizable areas including system windows don't really have a large hit box area for resizing. Even Figma's is pretty small.
  • Neither Figma nor storybook has special styling for when a resize is active. Its basically just the focus styling. I'm not sure we need special styling either. If we make the shell-panel content container focusable it could handle both keyboard resizing and focus styles.

@aPreciado88 aPreciado88 self-assigned this Aug 12, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. 0 - new New issues that need assignment. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Aug 12, 2024
@aPreciado88 aPreciado88 assigned SkyeSeitz and unassigned aPreciado88 Aug 19, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 23, 2024
@SkyeSeitz SkyeSeitz removed their assignment Sep 25, 2024
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

8 participants