Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split accordion-item header and content padding #10762

Open
3 of 5 tasks
alisonailea opened this issue Nov 18, 2024 · 4 comments
Open
3 of 5 tasks

split accordion-item header and content padding #10762

alisonailea opened this issue Nov 18, 2024 · 4 comments
Assignees
@alisonailea
Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-12-17 - Dec ...

Comments

@alisonailea
Copy link
Contributor

Check existing issues

Description

#10721 (review)

The current design pattern for accordion item is to have content and heading padding size in unison.

Acceptance Criteria

The proposed design pattern is accordion item heading and content padding size separately.

Relevant Info

No response

Which Component

accordion-item

Example Use Case

As a developer I want the padding of the accordion-item heading to be 10px and the content padding to be 0px.

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@alisonailea alisonailea added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@alisonailea alisonailea mentioned this issue Nov 18, 2024
Merged
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Nov 21, 2024
@geospatialem
Copy link
Member

@alisonailea Can you update the labels for verification? I've added in the labels and express triaged the above to November/current milestone.

@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 22, 2024

@alisonailea I think the padding token is still applying to both heading and content, but maybe I'm missing something.

Accordion demo page with calcite-accordion-item { --calcite-accordion-item-content-space: 40px; }:
https://github.com/user-attachments/assets/9aaea4fd-2668-42c1-8ac1-97826d5355bb

@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 22, 2024
@DitwanP DitwanP assigned alisonailea and unassigned geospatialem and DitwanP Nov 22, 2024
@alisonailea alisonailea mentioned this issue Nov 25, 2024
Merged
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 9, 2024
alisonailea added a commit that referenced this issue Dec 12, 2024
@alisonailea
fix(accordion-item): split header content padding (#10865)
e9e307c 
**Related Issue:** #10762

## Summary

Splits header and content padding rules so the token doesn't apply to
header
@geospatialem
Copy link
Member

@alisonailea It looks like the PR has been merged, is this issue ready for verification? If so, can you add the 3 - installed label for us? 🤜🏻 🤛🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonailea alisonailea

Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP