Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: calcite-value-list-item's label takes up space even if there is no content specified #3373

Closed
ptmdmusique opened this issue Oct 28, 2021 · 5 comments
Closed

Bug: calcite-value-list-item's label takes up space even if there is no content specified #3373

ptmdmusique opened this issue Oct 28, 2021 · 5 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 07/11 - 07/22

Comments

@ptmdmusique
Copy link
Contributor

ptmdmusique commented Oct 28, 2021 •
edited
Loading

Actual Behavior

calcite-value-list-item's label (which is inside calcite-pick-list-item) takes up space even if no label is passed as prop

Expected Behavior

the label should not take up space and we can stretch the actions-end or actions-start

Reproduction Steps and Sample

https://codepen.io/ptmdmusique/pen/YzxZaZK

cc @paulcpederson @abi11500

Relevant Info
@ptmdmusique ptmdmusique added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 28, 2021
@github-actions
Copy link
Contributor

More information is required to proceed with this issue:

  • Copy the appropriate issue template format and paste it into a comment, providing all of the requested items

This issue will be automatically closed in three days if the information is not provided. Thanks for your understanding.

@github-actions github-actions bot added the need more info Issues that are missing information and/or a clear, actionable description. label Oct 28, 2021
@benelan benelan removed the need more info Issues that are missing information and/or a clear, actionable description. label Oct 28, 2021
@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Nov 3, 2021
@jcfranco jcfranco mentioned this issue Nov 3, 2021
Closed
@y0n4 y0n4 self-assigned this Nov 24, 2021
y0n4 pushed a commit that referenced this issue Nov 29, 2021
style: minimize title/description space on the list when prop value i…
97b6fa6 
…s not provided (#3373)
@y0n4 y0n4 added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 29, 2021
@y0n4 y0n4 mentioned this issue Nov 29, 2021
Closed
@driskull
Copy link
Member

We might just need to improve documentation and make label required. Label is like a title and description is like a subtitle in this case. You can't have just a subtitle without a title.

@benelan @jcfranco Any suggestions on how we can catch these things before assignment? I don't want to waste dev time. Or we can communicate that issues require further investigation before proceeding with development.

@jcfranco
Copy link
Member

calcite-value-list-item#label is marked as required. Sidebar, calcite-pick-list-item#label is not. cc @benelan

@driskull Let me assure you that nobody wants to waste dev time, this just slipped through the cracks during triaging.

@benelan benelan removed this from the Sprint 01/31 - 02/11 milestone Feb 14, 2022
@driskull driskull self-assigned this Jul 12, 2022
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 12, 2022
driskull added a commit that referenced this issue Jul 12, 2022
@driskull
fix(pick-list-item): Make label property required. (#3373)
e54faf5
@driskull driskull mentioned this issue Jul 12, 2022
Closed
driskull added a commit that referenced this issue Jul 12, 2022
@driskull
fix(pick-list-item): Make label property required. (#3373)
a09657b
@driskull driskull mentioned this issue Jul 12, 2022
Merged
driskull added a commit that referenced this issue Jul 18, 2022
@driskull
fix(pick-list-item): Make label property required. (#3373) (#4907)
567a424
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 18, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned driskull Jul 18, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Aug 4, 2022

Woops the mention must have gotten buried in my emails, thanks for taking care of this Matt. Verified on master

@benelan benelan closed this as completed Aug 4, 2022
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 07/11 - 07/22
Development

No branches or pull requests
6 participants
@jcfranco @driskull @geospatialem @benelan @y0n4 @ptmdmusique