-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the internal contributing and conventions doc #3818
Labels
1 - assigned
Issues that are assigned to a sprint and a team member.
Calcite (dev)
Issues logged by Calcite developers.
discussion
Issues relating to a conversation where feedback is optional.
docs
Issues relating to documentation updates only.
p - low
Issue is non core or affecting less that 10% of people using the library
Milestone
Comments
benelan
added
discussion
Issues relating to a conversation where feedback is optional.
docs
Issues relating to documentation updates only.
1 - assigned
Issues that are assigned to a sprint and a team member.
labels
Dec 30, 2021
Jotting some ideas:
|
benelan
added a commit
that referenced
this issue
Sep 2, 2022
…5228) **Related Issue:** #3818 ## Summary - Added additional information to the contributing and documentation convention. - Fixed outdated info <!-- Please make sure the PR title and/or commit message adheres to the https://www.conventionalcommits.org/en/v1.0.0/ specification. Note: If your PR only has one commit and it is NOT semantic, you will need to either a. add another commit and wait for the check to update b. proceed to squash merge, but make sure the commit message is the same as the title. This is because of the way GitHub handles single-commit squash merges (see zeke/semantic-pull-requests#17) If this is component-related, please verify that: - [ ] feature or fix has a corresponding test - [ ] changes have been tested with demo page in Edge --- If this is skipping an unstable test: - include info about the test failure - submit an unstable-test issue by [choosing](https://github.com/Esri/calcite-components/issues/new/choose) the unstable test template and filling it out -->
3 tasks
Related: #7724 - could explore a new patterns documentation page which includes #3818 (comment) and |
geospatialem
modified the milestones:
2024 January Priorities - Main release,
2024 April Priorities
Dec 18, 2023
geospatialem
modified the milestones:
2024-04-30 - Apr Release,
2024-05-28 - May Main Release
Apr 15, 2024
geospatialem
modified the milestones:
2024-05-28 - May Main Release,
2024-07-30 - Jul Release
May 23, 2024
geospatialem
added
the
p - low
Issue is non core or affecting less that 10% of people using the library
label
Jun 13, 2024
geospatialem
modified the milestones:
2024-07-30 - Jul Release,
2024-08-27 - Aug Release
Jun 26, 2024
Confirmed w/ @benelan. This is no longer as we've started moving internal doc to our wiki. Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 - assigned
Issues that are assigned to a sprint and a team member.
Calcite (dev)
Issues logged by Calcite developers.
discussion
Issues relating to a conversation where feedback is optional.
docs
Issues relating to documentation updates only.
p - low
Issue is non core or affecting less that 10% of people using the library
Description
The goal is to get the internal doc looking like Hub's
I am going to break the conventions into different files by topic so that they can be items in the storybook sidebar like above.
I will audit the existing conventions and remove any that are no longer valid.
Then start beefing up the conventions with unspoken stuff we all just do. If you all think of anything specific that needs to be added to the conventions comment on this issue or edit the description below.
Which Component
NA
Resources
Specific conventions that need to be added (feel free to add more here)
cc @driskull @jcfranco @macandcheese
TODO
e: event
vsevent: event
)The text was updated successfully, but these errors were encountered: