Bug: Missing types when building from a new clone

[benelan]

Actual Behavior

Some of the components have missing types when building from a new clone. For example, here are the correct type files for calcite-combobox:
https://unpkg.com/browse/@esri/calcite-components@1.0.0-beta.78/dist/types/components/combobox/

And here is what it looks like when type files are missing:
https://unpkg.com/browse/@esri/calcite-components@1.0.0-beta.79/dist/types/components/combobox/

Expected Behavior

No missing type files when building

Reproduction Sample

N/A

Reproduction Steps

1. git clone https://github.com/Esri/calcite-components.git
2. cd calcite-components
3. npm ci && npm run build
4. Check for missing type files in dist/types/components/combobox

Reproduction Version

beta.79

Relevant Info

There are no errors in the console. The work around is to build again and make sure all the files are there.

I repro'd on WSL (Ubuntu 20.04)
@jcfranco repro'd on Mac

Regression?

No response

[github-actions]

More information is required to proceed with this issue:

• Provide a codepen, codesandbox, or jsbin that reproduces the issue. Alternatively, a documentation sample can be used if the issue is reproducible.

This issue will be automatically closed in five days if the information is not provided. Thanks for your understanding.

[Zay]

I can confirm that 4 type definitions are missing.
I used https://github.com/Esri/calcite-components-examples/angular (currently on beta-78)

and ran commands:

• npm install
• ng build
• ng serve

This works fine.

Then upgraded to version "1.0.0-beta.79" using
npm install @esri/calcite-components@latest

Getting the following errors on ng serve now:
ERROR in node_modules/@esri/calcite-components/dist/types/components.d.ts:19:61 - error TS2307: Cannot find module './components/combobox/interfaces'.

19 import { ComboboxChildElement, ComboboxSelectionMode } from "./components/combobox/interfaces";
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@esri/calcite-components/dist/types/components.d.ts:28:34 - error TS2307: Cannot find module './components/pagination/pagination'.

28 import { PaginationDetail } from "./components/pagination/pagination";
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@esri/calcite-components/dist/types/components.d.ts:29:29 - error TS2307: Cannot find module './components/pick-list/shared-list-logic'.

29 import { ListFocusId } from "./components/pick-list/shared-list-logic";
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/@esri/calcite-components/dist/types/components.d.ts:37:53 - error TS2307: Cannot find module './components/tree/interfaces'.

37 import { TreeSelectDetail, TreeSelectionMode } from "./components/tree/interfaces";

When comparing to .78, I'm seeing more typing files missing. The entire tree folder is missing, for instance.

[benelan]

@Zay we will be releasing beta.80 tonight to patch this issue.

[benelan]

Possibly related to stenciljs/core#3239

[benelan]

To recap, this issue occurs when you build w/o an existing components.d.ts file, which manifests in new clones since we don't commit the generated file. As mentioned above, doing a second build fixes the issue. This is a known Stencil issue, but we set up checks to prevent the missing types from making it into a release.

• chore: build prior to stencil test to fix missing types error #5323
• ci: check generated types before publishing #5062

Closing based on ☝️