Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check generated types before publishing #5062

Merged
merged 5 commits into from
Sep 20, 2022
Merged

ci: check generated types before publishing #5062

merged 5 commits into from
Sep 20, 2022

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Aug 1, 2022 •
edited by benelan
Loading

Summary

Adds a util script for testing types, which runs before releases as a sanity check. There are two parts to the util:

  1. Runs tsc to make sure there are no missing types or other errors.
  2. Checks to make sure 3rd party types packages are not imported in the build. This isn't caught in the above check, likely because the types packages are installed as devDependencies in the repo.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 9, 2022
@benelan benelan mentioned this pull request Sep 16, 2022
Merged
@benelan benelan marked this pull request as ready for review September 16, 2022 23:34
@benelan benelan requested a review from a team as a code owner September 16, 2022 23:34
benelan
benelan approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcfranco jcfranco changed the title chore: add type-testing util script ci: add type-testing check before publishing Sep 20, 2022
@jcfranco jcfranco changed the title ci: add type-testing check before publishing ci: check generated types before publishing Sep 20, 2022
@jcfranco jcfranco merged commit ae01711 into master Sep 20, 2022
@jcfranco jcfranco deleted the jcfranco/add-type-testing-util branch September 20, 2022 18:19
This was referenced Sep 21, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@jcfranco jcfranco

@benelan benelan

Labels
chore Issues with changes that don't modify src or test files. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
Sprint 2022/09/19 - 2022/09/30
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan