Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(next releases): check types before pushing tags #5367

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Sep 21, 2022

Related Issue: #5062

Summary

Reorganize the next release NPM scripts so that they are in line with the normal release ones. The push should happen in the util:publish-next script so that we don't run into an issue where a version pushes but doesn't get published to NPM.

@benelan benelan self-assigned this Sep 21, 2022
@benelan benelan requested a review from a team as a code owner September 21, 2022 01:31
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@benelan
Copy link
Member Author

benelan commented Sep 21, 2022

The failed test is unrelated and one of the unstable ones, I'm going to merge. cc @jcfranco

● calcite-action-bar › overflow actions › should slot 'menu-actions' on resize of component

@benelan benelan merged commit a7026cc into master Sep 21, 2022
@benelan benelan deleted the benelan/move-type-check branch September 21, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants