Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcite-list-item missing pointer cursor style #6123

Closed
mpayson opened this issue Dec 20, 2022 · 9 comments
Closed

calcite-list-item missing pointer cursor style #6123

mpayson opened this issue Dec 20, 2022 · 9 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.

Comments

@mpayson
Copy link

mpayson commented Dec 20, 2022

Actual Behavior

calcite-list-item does not use a pointer style for the cursor. Looks like this was fixed in #5880 but the pointer may have changed again?

cc @ethanbdev @AdelheidF @geospatialem

Expected Behavior

calcite-list-item uses the pointer style so the items appear clickable, see gif under "Expected behavior" here: #5880

Reproduction Sample

https://codepen.io/mpayson/pen/mdjdNBq

Reproduction Steps

  1. Open code pen
  2. Hover over an item

Reproduction Version

beta.99

Relevant Info

No response

Regression?

next.660

Impact

No response

Esri team

ArcGIS Online

@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2022
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Dec 20, 2022
@geospatialem
Copy link
Member

This seems to be a result of the selection-mode attribute, which is set to "none" by default. If adding selection-mode="multiple" or "single" the cursor is present.

<calcite-list selection-mode="single">
...
</calcite-list>

This seems to be the expected behavior, but we could add documentation to the component for additional context.

@mpayson
Copy link
Author

mpayson commented Dec 20, 2022

Ah interesting, is there a way to do this without the visual selected state?

Our use case is a user selects a processing tool from a list of options and that tool gets added to a processing model, I don't think it makes sense to keep the tool highlighted after the user chooses an option. They can select the same option twice and that tool should get added to the model twice, for example, and they aren't choosing one exclusive option

@geospatialem
Copy link
Member

Ah interesting, is there a way to do this without the visual selected state?

Not at this time. Prior to the refactor we had a nonInteractive property, but opted to remove it as we couldn't justify a use case compared to a selectionMode of "none".

The visual feedback is useful for more diverse audiences, so we decided to remove the nonInteractive prop. We'd likely need to consider the enhancement after next month's release after some team discussion.

Our use case is a user selects a processing tool from a list of options and that tool gets added to a processing model, I don't think it makes sense to keep the tool highlighted after the user chooses an option. They can select the same option twice and that tool should get added to the model twice, for example, and they aren't choosing one exclusive option

Good to know, don't believe we knew of a use case so good to get additional context.

For us to re-evaluate after next month's release, could you or the team add additional visuals for the expected behavior so when we are able to convene we can determine some viable options for consideration in a future release?

@ethanbdev ethanbdev added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Dec 20, 2022
@ethanbdev
Copy link
Contributor

The use case we have in the map viewer is in the issue linked that was originally open.. basically we use the list item to list tools that the user can select and open. The visual selection indicator does not make a lot of sense in this context as the panel changes when the user selects one of the tools.

We got feedback that not having pointer cursor styling feels a bit off, but is there a different component we could use to get this same effect maybe? The other list components also don't really fit the job it seems like

@mpayson
Copy link
Author

mpayson commented Dec 21, 2022

could you or the team add additional visuals for the expected behavior

Our use case is similar to Ethan's, the expected behavior is how the list works in beta.98 (hover pointer & background styles, no selection style or state). Here's a codepen using this version: https://codepen.io/mpayson/pen/NWBPMpM

@ashetland
Copy link
Contributor

Yep, this makes sense to me as well. If we do it on the selection modes, then we should be consistent and also do it when the mode is set to none for the use case outlined above.

@geospatialem
Copy link
Member

@driskull Going to add this to the January milestone to add the cursor pointer when selectionMode is "none" (default).

@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 21, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 21, 2022
@benelan benelan added the 2 - in development Issues that are actively being worked on. label Dec 30, 2022
@benelan benelan self-assigned this Dec 30, 2022
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Installed and assigned for verification.

benelan added a commit that referenced this issue Jan 5, 2023
**Related Issue:** #6123

## Summary
Add pointer cursor on hover
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 5, 2023
@geospatialem
Copy link
Member

Verified on next.710

verify-pointer-selection-none

driskull added a commit that referenced this issue Jan 18, 2024
**Related Issue:** #6700

## Summary

It was decided that the majority of cases use the layer list to perform
some kind of action so the default should be to have hover and pointer
styling by default. In the future, we may add another selectionMode to
provide a better UX for "non interactive" lists.

Further information:
#6123 (comment)

- Always has the hover and pointer styling on a list item regardless of
selectionMode
- Add e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

No branches or pull requests

5 participants