Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calcite-Combobox > Focus item in dropdown displays gray active dot #6245

Closed
3 tasks
Tracked by #7733
richiecarmichael opened this issue Jan 6, 2023 · 8 comments
Closed
3 tasks
Tracked by #7733
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@richiecarmichael
Copy link

richiecarmichael commented Jan 6, 2023

Description

The calcite combobox dropdown menu displays the currently selected item with a small blue dot (see "Carrot" below). The first item in the dropdown always has focus and is displayed with a blue outline and small gray dot (see "Apple" below).

The small gray dot next to Apple could be confusing to the user. Some users might this is it the default value, or perhaps original value.

image

// @adam

Acceptance Criteria

Refer to the Figma file.

  • Add foreground.3 bg on :pressed
  • Remove previewed grey dot or checkmark on combobox-item :focus
  • Do not show gray dot next for focused items in the calcite combobox dropdown.

Relevant Info

No response

Which Component

Combobox

Example Use Case

Multiple Selection

  1. https://developers.arcgis.com/calcite-design-system/components/combobox/
  2. Click comboxbox toggle button.
  3. Engineering is checked even though not added.

image

Single Selection

  1. https://developers.arcgis.com/calcite-design-system/components/combobox/
  2. Change selection-mode to "single"
  3. Click comboxbox toggle button.
  4. Engineering is dotted even though not added.

image

Esri team

ArcGIS Maps SDK for JavaScript

@richiecarmichael richiecarmichael added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 6, 2023
@github-actions github-actions bot added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Jan 6, 2023
@macandcheese
Copy link
Contributor

Thanks for opening @richiecarmichael - @ashetland @SkyeSeitz can we take a look at this?

I agree it may be confusing. Additionally, our behavior between Dropdown and Combobox are different. In Dropdown, hover shows the grey dot, while focus does not. In Combobox, hovering shows no dot, but focusing does. It seems like adopting the Dropdown approach in Combobox could solve potential confusion:

Additionally (may be a separate issue) - Dropdown automatically focuses the first (or only) selected item in the list, Combobox always seems to focus the first item whether there is an existing selection or not. Should we address that as well?

@ashetland
Copy link

I agree that adopting the Dropdown approach would help here and also improve consistency.

The focus issue is something we could dig into separately.

@macandcheese macandcheese added the c-combobox Issues that pertain to the calcite-combobox and related components label Mar 22, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Jan 22, 2024
@geospatialem geospatialem added the estimate - design - sm Small design effort; 1-4 days of design work label May 9, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 13, 2024

This is included in a larger epic #7733

@SkyeSeitz
Copy link

Discussed this with Aaron in context of our interaction state audit. I think we can move forward with this issue separately after all before further refinements to Combobox.

Here is the proposed design to remove the selection icon preview on focused Combobox Items:
image

@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Jun 17, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 17, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@SkyeSeitz
Copy link

Re: focus order, for Combobox it might make sense to default to focusing the last item selected in order to prioritize keeping selected items in view?

@DitwanP DitwanP added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Jul 11, 2024
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Aug 7, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Aug 7, 2024
@github-actions github-actions bot added the ArcGIS API for JavaScript Issues logged by ArcGIS API for JavaScript team members. label Aug 7, 2024
@geospatialem geospatialem removed the ArcGIS API for JavaScript Issues logged by ArcGIS API for JavaScript team members. label Aug 7, 2024
@jcfranco jcfranco self-assigned this Dec 2, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 2, 2024
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 3, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 6, 2024
@geospatialem
Copy link
Member

Verified on 3.0.0-next.51 with all selectionModes, for instance "multiple":
verify-combobox-active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. c-combobox Issues that pertain to the calcite-combobox and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

8 participants