Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox-item): update selection state according to spec #10945

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat(combobox-item): update selection state according to spec #10945

merged 2 commits into from
Dec 3, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 2, 2024 •
edited
Loading

Related Issue: #6245

Summary

This updates combobox-item to:

  • only display selection icon when selected
  • use foreground.3 when pressed

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 2, 2024
@jcfranco jcfranco changed the title feat(combobox): update selection state according to spec feat(combobox-item): update selection state according to spec Dec 2, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
ashetland
ashetland requested changes Dec 3, 2024
View reviewed changes
Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing a ghosted selection icon while hovering on disabled items 🫠

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 3, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Dec 3, 2024

@ashetland Fixed!

@jcfranco jcfranco requested a review from ashetland December 3, 2024 07:03
ashetland
ashetland approved these changes Dec 3, 2024
View reviewed changes
Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcfranco jcfranco merged commit 1bfdaca into dev Dec 3, 2024
14 checks passed
@jcfranco jcfranco deleted the jcfranco/6245-fix-combobox-active-hover-state branch December 3, 2024 17:25
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

@eriklharper eriklharper Awaiting requested review from eriklharper

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @ashetland