Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rating] Focus outline not present with mouse selection #6642

Closed
geospatialem opened this issue Mar 23, 2023 · 2 comments
Closed

[Rating] Focus outline not present with mouse selection #6642

geospatialem opened this issue Mar 23, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 August Prior...

Comments

@geospatialem
Copy link
Member

Actual Behavior

When selecting the rating (in focus), shows the focus outline. However, the focus outline does not show when interacting and selecting the rating with a mouse.

Discovered while conducting an audit on #4633 cc @ashetland

Rating.focus.bug.mp4

Expected Behavior

Should perform similar to the tabs or pagination components when selection occurs with a mouse.

expected-result

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/rating/

Reproduction Steps

  1. Open the sample
  2. Navigate through the component using the keyboard and observe the proper focus
  3. Navigate the component with a mouse and observe the focus is not present

Reproduction Version

1.1.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

Moderate - a nice to have feature, but not a critical a11y prioritization.

Esri team

Calcite (design)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. 0 - new New issues that need assignment. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Mar 23, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Mar 23, 2023
@geospatialem geospatialem added this to the 2023 November Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@anveshmekala anveshmekala mentioned this issue Aug 9, 2023
Merged
anveshmekala added a commit that referenced this issue Aug 26, 2023
@anveshmekala
fix(rating): adds focus outline on click (#7341)
af30073 
**Related Issue:** #4633 ,
#6642

## Summary

This PR will add focus outline for `calcite-rating` component on click.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Aug 26, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 27, 2023
@geospatialem
Copy link
Member Author

Verified in 1.7.0-next.9.

Elijbet pushed a commit that referenced this issue Aug 30, 2023
@anveshmekala @Elijbet
fix(rating): adds focus outline on click (#7341)
6ce661f 
**Related Issue:** #4633 ,
#6642

## Summary

This PR will add focus outline for `calcite-rating` component on click.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 August Priorities
Development

No branches or pull requests
2 participants
@geospatialem @anveshmekala