Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input type number does not work with French (F) AZERTY keyboard layout #6854

Closed
ChristopheSuter opened this issue Apr 25, 2023 · 10 comments
Closed

Input type number does not work with French (F) AZERTY keyboard layout #6854

ChristopheSuter opened this issue Apr 25, 2023 · 10 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone research Issues that require more in-depth research or multiple team members to resolve or make decision.
Milestone
2023 June patch p...

Comments

@ChristopheSuter
Copy link

Actual Behavior

Problem when using calcite input type number with French (France) keyboard layout AZERTY on keyboards without numeric pad.

The user needs to hold the [SHIFT] key to enter numbers and this does not work (no input token) on calcite input but does work on native input type number

Expected Behavior

Input should work as native input

Reproduction Sample

https://codepen.io/geospatialem/pen/QWZpepg

Reproduction Steps

Change your keyboard layout to French (France) and try to input number :
https://codepen.io/geospatialem/pen/QWZpepg

Reproduction Version

1.2.0

Relevant Info

MacOS/Chrome

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

User can not use input

Esri team

N/A
@ChristopheSuter ChristopheSuter added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 25, 2023
@github-actions github-actions bot added the impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone label Apr 25, 2023
@jcfranco jcfranco added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Apr 27, 2023
@geospatialem
Copy link
Member

This was also reported as BUG-000157826.

@annierm18 annierm18 added the i18n-l10n issues dealing with internationalization/localization label May 15, 2023
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Jun 1, 2023
@geospatialem
Copy link
Member

possibly related #7039

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 1, 2023
@eriklharper
Copy link
Contributor

eriklharper commented Jun 8, 2023 •
edited
Loading

@ChristopheSuter what platform and browser are you running that allows you to type the non-number pad numeric keys in the native html number input? I'm on macOS Ventura 13.4 and this the behavior I see when I type 1234567890 on the non-number pad keys in the following browsers:

Safari:
image

Firefox
image

Brave
image

Chrome
image

@eriklharper
Copy link
Contributor

This is the keyboard I've selected in the system settings input sources option
image

@ChristopheSuter
Copy link
Author

ChristopheSuter commented Jun 9, 2023 •
edited
Loading

Ventura 13.3.1 and Chrome
Make sure it is the only layout in your settings ..
image
Using [SHIFT] key ...
image

@eriklharper
Copy link
Contributor

Hmm... still can't replicate it, even after removing all input sources except ABC - AZERTY. Does it require a system restart after applying those changes?

@anveshmekala
Copy link
Contributor

i am able to reproduce the error with Ventura 13.3.1 and Chrome.

@anveshmekala anveshmekala self-assigned this Jun 22, 2023
@anveshmekala anveshmekala mentioned this issue Jun 22, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 22, 2023
anveshmekala added a commit that referenced this issue Jun 26, 2023
@anveshmekala
fix(input, input-number): allows numeric characters. (#7213)
739f0af 
**Related Issue:** #6854 

## Summary

This PR will support French AZERTY keyboard layout in `calcite-input` &
`calcite-input-number`
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 26, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

A fix has been added to our latest release, 1.4.3.

@ChristopheSuter could you verify if the fix is mitigated with the AZERTY keyboard and input where type="number" in this sample?

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 3, 2023
@geospatialem
Copy link
Member

Verified on Mac OS in Chrome with this sample in 1.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone research Issues that require more in-depth research or multiple team members to resolve or make decision.
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
6 participants
@jcfranco @eriklharper @geospatialem @annierm18 @ChristopheSuter @anveshmekala