Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[color-picker] add clearable property and deprecate allowEmpty #6880

Closed
jcfranco opened this issue Apr 27, 2023 · 2 comments
Closed

[color-picker] add clearable property and deprecate allowEmpty #6880

jcfranco opened this issue Apr 27, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-03-26 - Mar ...

Comments

@jcfranco
Copy link
Member

Description

For consistency, the color-picker should use clearable for the value-clearing behavior.

Acceptance Criteria

  1. clearable property is added
  2. allowEmpty is deprecated

Relevant Info

No response

Which Component

calcite-color-picker

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (dev)
@jcfranco jcfranco added enhancement Issues tied to a new feature or request. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Apr 27, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (dev) Issues logged by Calcite developers. labels Apr 27, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@geospatialem geospatialem added this to the 2024 March Priorities milestone Nov 22, 2023
@Elijbet Elijbet self-assigned this Mar 7, 2024
@Elijbet Elijbet added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 7, 2024
@Elijbet Elijbet mentioned this issue Mar 7, 2024
Closed
@brandentheintern brandentheintern mentioned this issue Mar 8, 2024
Merged
brandentheintern added a commit that referenced this issue Mar 19, 2024
@brandentheintern
feat(color-picker): add clearable prop and deprecate allowEmpty (#…
f036ac2 
…8910)

**Related Issue:** #6880

## Summary
Added clearable to contribute to continuity within the codebase - the
logic allows for allowEmpty & clearable to be utilized to allow null
values in the color picker.
@brandentheintern brandentheintern added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 21, 2024
@geospatialem
Copy link
Member

Verified in 2.7.0-next.11 with both the new clearable and deprecated allow-empty attributes. ✨👍🏻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @Elijbet @DitwanP @brandentheintern