Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chevron icon should be 24px (medium) on large scale Input Date/Time Pickers #6889

Closed
ashetland opened this issue Apr 28, 2023 · 2 comments
Closed

Chevron icon should be 24px (medium) on large scale Input Date/Time Pickers #6889

ashetland opened this issue Apr 28, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 October Prio...

Comments

@ashetland
Copy link
Contributor

Actual Behavior

The chevron icons are set to small scale.
CleanShot 2023-04-28 at 15 23 07@2x
CleanShot 2023-04-28 at 15 23 36@2x

Expected Behavior

They should be set to medium scale to match the size of the other icons.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/input-time-picker/

Reproduction Steps

  1. Open component sample
  2. Select Input Time Picker or Input Date Picker
  3. Change scale to large

Reproduction Version

1.3

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 28, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Apr 28, 2023
@jcfranco jcfranco added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 28, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@geospatialem geospatialem added the good first issue Issues that can be worked on by contributors new to calcite-components. label Sep 21, 2023
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@jcfranco jcfranco self-assigned this Oct 13, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 13, 2023
@jcfranco jcfranco mentioned this issue Oct 13, 2023
Merged
jcfranco added a commit that referenced this issue Oct 20, 2023
@jcfranco
fix(input-date-picker, input-time-picker): adjust chevron scale accor…
f894f80 
…dingly (#8012)

**Related Issue:** #6889

## Summary

Uses `getIconScale` to apply corresponding scale to internal chevron
icon.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 20, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 20, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 25, 2023
@geospatialem
Copy link
Member

Verified in 1.10.0-next.7 of 24px on the icon when scale="l".

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @ashetland @brittneytewks