Redundant attributes in modal's built-in close button

[phenderson00]

Actual Behavior

The CalciteModal's built-in close button has both of the following attributes: title and aria-label. Both attributes are being set to the string "Close". Setting both attributes to the same value is redundant.

Expected Behavior

Either the title or aria-label attribute should be removed in order to eliminate redundancy. If the intention is to display a tool tip on hover, the aria-label can be removed.

Reproduction Sample

https://codesandbox.io/s/calcite-modal-button-a11y-bug-s2lsiz?file=/src/App.js

Reproduction Steps

1. Open the DevTools console
2. Click the Launch Modal button
3. Use the element selector to select the modal's close (X) button
4. See that the title and aria-label attributes on the button are both set to "Close"

Reproduction Version

1.4.2

Relevant Info

Windows 10, Chrome 114.0.5735.90

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

This does not block our project, but the accessibility tester on the customer's side is the one who brought this issue to our attention.

Esri team

Professional Services - Midwest Delivery Center

[driskull]

I'm not sure its redundant since the title is for the tooltip and the aria-label is for screen readers. Is it repeating the same text in a screen reader?

[phenderson00]

That's exactly correct. We're hearing the same text being read twice by the screenreader.

[driskull]

Gotcha. thanks! We can remove the title attribute I think.

[geospatialem]

We're hearing the same text being read twice by the screenreader.

Was able to repro with NVDA across browsers - both JAWS and VoiceOver are not affected. This doesn't seem to be related to the aria-label and title, but rather the dialog role with NVDA mentioned in an issue on their repo at nvaccess/nvda#8971.

The issue highlights a sample showcasing the behavior in NVDA.

[geospatialem]

Closing this issue as not planned, as it pertains to a NVDA bug. re: #7125 (comment).

For additional context, previously the title and aria-label sequence was an issue with NVDA, but was mitigated in September 2021.