Block: remove redundant indicator behavior

[SkyeSeitz]

Check existing issues

• I have checked for existing issues to avoid duplicates

Description

Current behavior
Loader populates both in the header and in the content area when expanded, which feels redundant and may imply two separate elements are loading.

Acceptance Criteria

Expected behavior
Loader populates only in header when collapsed and only in content area when expanded.

Relevant Info

Building off of #6485

Which Component

Calcite Block

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

• @esri/calcite-components
• @esri/calcite-components-react

Esri team

Calcite (design)

[github-actions]

cc @geospatialem, @brittneytewks

[SkyeSeitz]

cc @ashetland

[ashetland]

@macandcheese @asangma Is there a reason use case for having a loading indicator in the header while it's expanded that we're missing?

[macandcheese]

Not from my side. I do think it's strange the loader replaces the icon at all...

I wonder if a calcite-progress on the top of the block would make sense? It would eliminate the need to replace a user-placed element, and could subtly persist even while the block was expanded + calcite-loader present to prevent hiding / showing elements when expanding / collapsing. You do kind of lose the immediacy of the spinner being centered within the item when blocks are all collapsed, but this kind of loading often seen in "listy places" as well across Apps...

Screen.Recording.2023-08-08.at.5.00.07.PM.mov

[macandcheese]

I do like that the loader within the Block content area is smaller in the above screenshots - depending on height of Block content, it can feel too large currently.

[ashetland]

From #7147 and #7420, the loader size should be changing based on the height of the container. Those breakpoints can definitely be revised if we want to.

I like using Progress too, but I do see one drawback: when all the Blocks are collapsed it's hard to tell which one is actually loading.

[SkyeSeitz]

Yea, it would be a somewhat learned behavior that the Progress bar represents the Block below it.
Other than that, I am digging the Progress bar as perhaps a more elegant solution. The dimmed treatment is also nice, however, I think I would ultimately say it probably does not need to persist when Block is expanded to simplify the amount of Loading indicators.

[brittneytewks]

Removed Figma changes label as this will be tracked in monday.com

[ashetland]

How do we feel about moving forward with this? Based on @SkyeSeitz's comment, would it work to use Progress to indicate loading only while Block is collapsed?

[SkyeSeitz]

After research and exploration, there is not currently a great solution to move towards. Since this is a Calcite logged issue and low priority, we don't want to change anything until we have sufficient info on issues this causes the user.

@geospatialem can we move this to the freezer and bring it back in play if this issue comes up again in a more user-lead use case? TY