Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite Block header-menu-actions popover style/direction control #7516

Closed
3 tasks done
RSantosGIS opened this issue Aug 14, 2023 · 6 comments
Closed
3 tasks done

Calcite Block header-menu-actions popover style/direction control #7516

RSantosGIS opened this issue Aug 14, 2023 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Milestone
2024-09-30 - 2.13...

Comments

@RSantosGIS
Copy link

Check existing issues

Description

I would like to have the same options for positioning the Block header-menu-actions overflow popover/dropdown menu that I do for the Calcite Dropdown

  • overlay positioning, to allow me to overflow the parent container
  • placement (with extended options), to allow me to position it in the start/end of the left/right/top/bottom

You can see how this doesn't feel great below:

Collapsed Behavior:
image

Expanded Behavior:
image

Desired Behavior (achieved with a Calcite list item under the block using a dropdown, since our sublayers don't need to be expanded further):
image

Acceptance Criteria

Block header-menu-actions has same placement options as dropdown

Relevant Info

No response

Which Component

Calcite Block

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Knowledge
@RSantosGIS RSantosGIS added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 14, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. calcite-components-react Issues specific to the @esri/calcite-components-react package. labels Aug 14, 2023
@jcfranco
Copy link
Member

Thanks for submitting this.

Could you clarify which component you're using in your screenshots? Block doesn't have a menu.

@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label Aug 15, 2023
@RSantosGIS
Copy link
Author

Just Calcite Block with Calcite actions that are in the blocks header-menu-actions slot:

image

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed need more info Issues that are missing information and/or a clear, actionable description. needs triage Planning workflow - pending design/dev review. labels May 28, 2024
@geospatialem
Copy link
Member

Spike needed to determine which components should accommodate placement, such as block, panel, action-group, etc.

@driskull
Copy link
Member

driskull commented Sep 9, 2024

Seems like we should just add placement and flipPlacements properties to all three of these components.

@driskull driskull self-assigned this Sep 9, 2024
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 9, 2024
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Sep 9, 2024
driskull added a commit that referenced this issue Sep 9, 2024
@driskull
feat(action-group, block, panel): add 'placement' and 'flipPlacements…
e31a3ce 
…' properties. #7516
@driskull driskull mentioned this issue Sep 9, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 10, 2024
driskull added a commit that referenced this issue Sep 25, 2024
@driskull
feat(action-group, block, panel): add menuPlacement and `menuFlipPl…
5ba3112 
…acements` properties (#10249)

**Related Issue:** #7516

## Summary

- add `menuFlipPlacements` property
- add `menuPlacement` property
- add tests
- update stories
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 26, 2024

🍭 Verified locally on dev

One example below, menuPlacement: bottom & menuFlipPlacements: ["left"]

Screen.Recording.2024-09-26.at.9.09.52.AM.mov

@DitwanP DitwanP closed this as completed Sep 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-components-react Issues specific to the @esri/calcite-components-react package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @RSantosGIS @DitwanP