Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: add oldIndex and newIndex values to calciteListOrderChange event detail #7875

Closed
2 of 4 tasks
driskull opened this issue Sep 25, 2023 · 2 comments
Closed
2 of 4 tasks

List: add oldIndex and newIndex values to calciteListOrderChange event detail #7875

driskull opened this issue Sep 25, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 September Pr...

Comments

@driskull
Copy link
Member

Check existing issues

Description

Add additional event details to custom event

Acceptance Criteria

List: add oldIndex and newIndex values to calciteListOrderChange event detail

Relevant Info

No response

Which Component

List

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 25, 2023
@driskull driskull mentioned this issue Sep 25, 2023
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 25, 2023
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Sep 27, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 27, 2023
@driskull driskull self-assigned this Sep 27, 2023
@driskull driskull added the estimate - 2 Small fix or update, may require updates to tests. label Sep 27, 2023
driskull added a commit that referenced this issue Sep 27, 2023
@driskull
feat(list): add newIndex and oldIndex event details to calciteListOrd…
0d5cc20 
…erChange event (#7874)

**Related Issue:** #7875

## Summary

- Add more useful event details to `calciteListOrderChange` event
- Adds `oldIndex` and `newIndex` properties to the event detail
- Adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 28, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.12 with:

document.querySelector("calcite-list").addEventListener("calciteListOrderChange", (evt) => {
  console.log(evt.detail.oldIndex);
  console.log(evt.detail.newIndex);
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
3 participants
@jcfranco @driskull @geospatialem