Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Action Bar] overflow logic doesn't ungroup menu-item actions #7881

Closed
2 of 4 tasks
gopal-y opened this issue Sep 26, 2023 · 2 comments
Closed
2 of 4 tasks

[Action Bar] overflow logic doesn't ungroup menu-item actions #7881

gopal-y opened this issue Sep 26, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Milestone
2023 September Pr...

Comments

@gopal-y
Copy link
Member

gopal-y commented Sep 26, 2023

Check existing issues

Actual Behavior

Action bar when overflowActionsDisabled: false, which is default, fails to repopulate the action elements in the menu slot until the wrapping component is resized to a very larger width.

Expected Behavior

Add the action elements in the menu slot to the action bar default slot, when the width of the wrapping container is just enough to contain it.

Reproduction Sample

https://codepen.io/im-the-developer/full/qBLooXP

Reproduction Steps

  1. Open the app
  2. click on the OrientedImageryAction
  3. A widget is displayed in a resizable calcite-shell-panel to the right of the app
  4. Try resizing the shell-panel to a smaller width it can be observed that the action elements are moved to menu slot
  5. Now resize the shell panel to a width which can contain the entire actions, it can be observed that the action elements are still in the menu slot.
  6. Resize the shell panel to even larger width, it can be observed that the action elemnts are now visible in the default slot
    calcite-action-bar-bug.webm

Reproduction Version

1.4.2

Relevant Info

Windows 10, Microsoft Edge

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@gopal-y gopal-y added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2023
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Sep 26, 2023
@driskull driskull self-assigned this Sep 26, 2023
@driskull driskull linked a pull request Sep 26, 2023 that will close this issue
fix(action-bar): overflow actions when overflowActionsDisabled is set to false #7873
Merged
@driskull driskull mentioned this issue Sep 26, 2023
Merged
@driskull driskull removed a link to a pull request Sep 26, 2023
fix(action-bar): overflow actions when overflowActionsDisabled is set to false #7873
Merged
driskull added a commit that referenced this issue Sep 26, 2023
@driskull
fix(action-bar): Improve overflowing horizontal actions. (#7877)
52f2d2a 
**Related Issue:** #7881

## Summary

- Do not count slotted menu actions towards average action width
- Screenshot test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Sep 26, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Sep 26, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Sep 28, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 28, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.12.

verify-7881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @gopal-y