Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox chevron is wrong size at scale="l" #8067

Closed
2 of 5 tasks
ashetland opened this issue Oct 26, 2023 · 2 comments
Closed
2 of 5 tasks

Combobox chevron is wrong size at scale="l" #8067

ashetland opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests.

Comments

@ashetland
Copy link

ashetland commented Oct 26, 2023

Check existing issues

Actual Behavior

Large scale Combobox uses a small scale chevron (16px).

Expected Behavior

To match the rest of the system, it should be using a medium scale chevron (24px).

Reproduction Sample

https://codepen.io/ashetland/pen/NWoGaoE?editors=1000

Reproduction Steps

  1. Open the codepen
  2. Make a selection
  3. Note the size of the x icons vs the chevron

Reproduction Version

v1.9.2

Relevant Info

cc @jcfranco

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 26, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels Oct 26, 2023
@jcfranco jcfranco added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Oct 27, 2023
@jcfranco jcfranco self-assigned this Oct 27, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Oct 27, 2023
jcfranco added a commit that referenced this issue Oct 30, 2023
**Related Issue:** #8067

## Summary

Uses `getIconScale` util to set proper scale for placeholder and chevron
icons.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 30, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Oct 30, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 30, 2023
@geospatialem
Copy link
Member

Verified on main when the combobox is set to scale of "large".

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests.
Projects
None yet
Development

No branches or pull requests

3 participants