Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox] Expose label prop #8182

Closed
2 of 5 tasks
geospatialem opened this issue Nov 16, 2023 · 2 comments
Closed
2 of 5 tasks

[Checkbox] Expose label prop #8182

geospatialem opened this issue Nov 16, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 November Pri...

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

The checkbox does not support a label to provide context for AT as-is, but there is an internal prop.

Expected Behavior

Expose the checkbox's label prop to provide additional context to the component.

Reproduction Sample

https://codepen.io/geospatialem/pen/GRzOjRB?editors=100

Reproduction Steps

  1. Open the sample
  2. Observe the label property does not add an aria-label

Reproduction Version

1.10.0

Relevant Info

Likely made unintentional as a result of the accessible test. Mentioned in an internal teams discussion to expose the label prop.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 16, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Nov 16, 2023
@geospatialem geospatialem mentioned this issue Nov 16, 2023
Merged
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 16, 2023
@benelan benelan added this to the 2023 November Priorities milestone Nov 16, 2023
@benelan benelan self-assigned this Nov 16, 2023
@benelan benelan added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Nov 16, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed needs triage Planning workflow - pending design/dev review. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. labels Nov 16, 2023
benelan added a commit that referenced this issue Nov 16, 2023
@benelan
fix(checkbox): make label property public (#8181)
d3b9c1f 
Related issue: #8182

## Summary

The `label` property was unintentionally marked as internal.
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 16, 2023
@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 16, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned benelan Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 16, 2023
@geospatialem
Copy link
Member Author

Verified in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
3 participants
@geospatialem @benelan @DitwanP