Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List, Stack: action menus and handles slotted into list item and stack are not stretched to full height #8187

Closed
2 of 5 tasks
driskull opened this issue Nov 16, 2023 · 2 comments
Closed
2 of 5 tasks

List, Stack: action menus and handles slotted into list item and stack are not stretched to full height #8187

driskull opened this issue Nov 16, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 November Pri...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

When an action-menu or handle component is slotted inside a list-item or stack component it does not get the full height.

Expected Behavior

They should be stretched vertically just like the action slotted components are.

Reproduction Sample

https://codepen.io/driskull/pen/wvNPYYg?editors=1010

Reproduction Steps

  1. Open the sample app
  2. Inspect the height of the height of the banana action
  3. Inspect the height of the handle component
  4. Inspect the height of the action-menu component
  5. All three should be the same height.

Reproduction Version

1.10

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 16, 2023
@driskull driskull self-assigned this Nov 16, 2023
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 16, 2023
@driskull driskull added this to the 2023 November Priorities milestone Nov 16, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Nov 16, 2023
@driskull driskull mentioned this issue Nov 16, 2023
Merged
@driskull driskull added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Nov 16, 2023
driskull added a commit that referenced this issue Nov 16, 2023
@driskull
fix(list-item, stack): stretch action-menu and handle when placed ins…
8a16a69 
…ide a list-item or stack. (#8185)

**Related Issue:** #8187

## Summary

- Adds css to stack and list-item to treat an action-menu the same as an
action
- This makes the action take up the full height of the list-item/stack
- Previously, the action-menu would stop at 32x32 pixels.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Nov 16, 2023
DitwanP pushed a commit that referenced this issue Nov 16, 2023
@driskull @DitwanP
fix(list-item, stack): stretch action-menu and handle when placed ins…
efc1dd4 
…ide a list-item or stack. (#8185)

**Related Issue:** #8187

## Summary

- Adds css to stack and list-item to treat an action-menu the same as an
action
- This makes the action take up the full height of the list-item/stack
- Previously, the action-menu would stop at 32x32 pixels.
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2023
@geospatialem
Copy link
Member

Verified on the main branch.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP