Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropdown: the arrow-down/arrow-up keys should open a dropdown #8205

Closed
2 of 5 tasks
driskull opened this issue Nov 17, 2023 · 4 comments
Closed
2 of 5 tasks

dropdown: the arrow-down/arrow-up keys should open a dropdown #8205

driskull opened this issue Nov 17, 2023 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-09-30 - 2.13...

Comments

@driskull
Copy link
Member

driskull commented Nov 17, 2023 •
edited
Loading

Check existing issues

Summary

dropdown: the arrow-down/arrow-up keys should open a dropdown

Actual Behavior

Arrow keys have no effect.

Expected Behavior

Using the arrow keys on a trigger should open the dropdown component.

Reproduction Sample

https://codepen.io/driskull/pen/RwvxBZG?editors=1000

Reproduction Steps

  1. focus on the "plus" action
  2. Use arrow down or arrow up key
  3. Nothing happens

Reproduction Version

1.10

Working W3C Example/Tutorial

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role#keyboard_interactions

Relevant Info

image

Regression?

No response

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 17, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 17, 2023
@driskull driskull mentioned this issue Nov 17, 2023
Closed
5 tasks
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality needs triage Planning workflow - pending design/dev review. labels Dec 11, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
@aPreciado88 aPreciado88 self-assigned this Aug 27, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Aug 27, 2024
@aPreciado88 aPreciado88 removed their assignment Aug 29, 2024
@aPreciado88 aPreciado88 added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 29, 2024
@anveshmekala anveshmekala self-assigned this Sep 10, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Sep 10, 2024
@anveshmekala anveshmekala mentioned this issue Sep 10, 2024
Merged
@jcfranco
Copy link
Member

jcfranco commented Sep 10, 2024 •
edited
Loading

We should look at other components with the same role to fix similarly. cc @geospatialem

@jcfranco
Copy link
Member

Looks like it's just menu-item. The internal action-menu already supports this. 🎉

anveshmekala added a commit that referenced this issue Sep 25, 2024
@anveshmekala
fix(dropdown): open dropdown on ArrowDown & ArrowUp keys (#10264)
98548e4 
**Related Issue:** #8205 

## Summary

Open dropdown and focus first item on `ArrowDown`
Open dropdown and focus last item on `ArrowUp`

If any of the items is `selected` , both `ArrowDown` & `ArrowUp` keys
focus the selected item.
@anveshmekala anveshmekala removed the 2 - in development Issues that are actively being worked on. label Sep 25, 2024
@anveshmekala anveshmekala added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Sep 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Sep 26, 2024

🍡 Verified locally on dev

Screen.Recording.2024-09-26.at.8.00.48.AM.mov

What's shown in the recording is me using the up and down arrows to open the dropdown.

@DitwanP DitwanP closed this as completed Sep 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 26, 2024
@nwhittaker nwhittaker mentioned this issue Oct 22, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
6 participants
@jcfranco @driskull @geospatialem @DitwanP @anveshmekala @aPreciado88