Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-modal, calcite-dropdown : rename width prop to widthScale #8250

Closed
3 of 7 tasks
anveshmekala opened this issue Nov 22, 2023 · 2 comments
Closed
3 of 7 tasks

calcite-modal, calcite-dropdown : rename width prop to widthScale #8250

anveshmekala opened this issue Nov 22, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 November Pri...

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Nov 22, 2023 •
edited
Loading

Description

rename width prop in calcite-modal and calcite-dropdown with widthScale to be consistent with pattern in calcite-sheet and shell-panel

Proposed Advantages

  • Helps in providing consistent API across the repo .
  • Provides pattern for using width vs widthScale

Which Component

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@anveshmekala anveshmekala added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 22, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Nov 22, 2023
This was referenced Nov 22, 2023
Merged
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 22, 2023
@anveshmekala anveshmekala self-assigned this Nov 22, 2023
@anveshmekala anveshmekala removed the needs triage Planning workflow - pending design/dev review. label Nov 22, 2023
@jcfranco jcfranco changed the title calcite-modal,calcite-dropdown : rename width prop to widthScale calcite-modal, calcite-dropdown : rename width prop to widthScale Nov 22, 2023
@jcfranco jcfranco added this to the 2023 November Priorities milestone Nov 22, 2023
anveshmekala added a commit that referenced this issue Nov 22, 2023
@anveshmekala
refactor(modal)!: rename width property to widthScale (#8252)
2bcf474 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
anveshmekala added a commit that referenced this issue Nov 22, 2023
@anveshmekala
refactor(dropdown)!: rename width property to widthScale (#8251)
bf90796 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned anveshmekala Nov 22, 2023
benelan pushed a commit that referenced this issue Nov 23, 2023
@anveshmekala @benelan
refactor(modal)!: rename width property to widthScale (#8252)
330f966 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Nov 23, 2023
@anveshmekala @benelan
refactor(dropdown)!: rename width property to widthScale (#8251)
4ad4dd3 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Nov 29, 2023
@anveshmekala @benelan
refactor(modal)!: rename width property to widthScale (#8252)
e13795a 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Nov 29, 2023
@anveshmekala @benelan
refactor(dropdown)!: rename width property to widthScale (#8251)
7d9e242 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
@geospatialem geospatialem mentioned this issue Dec 1, 2023
Merged
geospatialem added a commit that referenced this issue Dec 1, 2023
@geospatialem
docs(modal): update fullscreen context to updated widthScale prop (#8313
adf1a16 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2023
@geospatialem
Copy link
Member

Verified on the rc branch.

benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(modal)!: rename width property to widthScale (#8252)
f48c24f 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(dropdown)!: rename width property to widthScale (#8251)
0ed9d3f 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 1, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
58ec5cb 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(modal)!: rename width property to widthScale (#8252)
6c337d3 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 1, 2023
@anveshmekala @benelan
refactor(dropdown)!: rename width property to widthScale (#8251)
8d7602e 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 1, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
26aff17 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
benelan pushed a commit that referenced this issue Dec 2, 2023
@anveshmekala @benelan
refactor(modal)!: rename width property to widthScale (#8252)
6b09245 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 2, 2023
@anveshmekala @benelan
refactor(dropdown)!: rename width property to widthScale (#8251)
ab12968 
**Related Issue:** #8250 

## Summary

BREAKING CHANGE: For consistency, renames `width` property to
`widthScale`.
benelan pushed a commit that referenced this issue Dec 2, 2023
@geospatialem @benelan
docs(modal): update fullscreen context to updated widthScale prop (#8313
1d7a64c 
)

**Related Issue:** #8250

## Summary
Updates the `modal`'s `fullscreen` prop context to the updated
`widthScale` prop (previously named `scale`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @DitwanP @anveshmekala