Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Add support for a new token for the component's color and remove last remaining -ui-named css var #8549

Closed
4 tasks done
geospatialem opened this issue Jan 3, 2024 · 2 comments
Closed
4 tasks done

[Icon] Add support for a new token for the component's color and remove last remaining -ui-named css var #8549

geospatialem opened this issue Jan 3, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-08-27 - Aug ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Jan 3, 2024 •
edited by alisonailea
Loading

Check existing issues

Description

Update the --calcite-ui-icon-color to reflect our new naming convention without the -ui- reference, in alignment with our other tokens.

Related issue: #7180

Acceptance Criteria

  • Add a component token for icon, currently depicted as --calcite-ui-icon-color
  • Continue to support --calcite-ui-icon-color as a legacy option for folks, deprecating the current value

Relevant Info

Pertains to the component specific css:

calcite-design-system/packages/calcite-components/src/components/icon/icon.scss

Line 6 in 624c8b4

* @prop --calcite-ui-icon-color: The component's color. Defaults to `currentColor`.

Which Component

icon

Example Use Case

Current implementation: https://codepen.io/geospatialem/pen/gOEPrYz

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-design-tokens

Esri team

Calcite (dev)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library design-tokens Issues requiring design tokens. labels Jan 3, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. p3 - want for upcoming milestone labels Jan 3, 2024
@geospatialem geospatialem mentioned this issue Jan 3, 2024
Open
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. estimate - 2 Small fix or update, may require updates to tests. 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. 0 - new New issues that need assignment. labels Aug 6, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Aug 8, 2024
@alisonailea alisonailea mentioned this issue Aug 14, 2024
Merged
@github-actions github-actions bot added the p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone label Aug 14, 2024
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. p3 - want for upcoming milestone User set priority status of p3 - want for upcoming milestone labels Aug 14, 2024
alisonailea added a commit that referenced this issue Aug 27, 2024
@alisonailea
feat(icon): add component tokens (#10062)
34d5689 
**Related Issue:** #7180, #8549

## Summary

Adds component tokens for Calcite Icon

--calcite-icon-color: Specifies the component's color. Defaults to
`currentColor`

Deprecates
--calcite-ui-icon-color
@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 27, 2024
@github-actions github-actions bot assigned DitwanP and unassigned alisonailea Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 27, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Aug 27, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP